'Re: Review Request 124931: [lookandfeel] Fix errors on startup of lockscreen greeter'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 124931: [lookandfeel] Fix errors on startup of lockscreen greeter
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2015-08-31 12:16:06
Message-ID: 20150831121606.10622.43219 () mimi ! kde ! org
[Download RAW message or body]

--===============6890486227507698115==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124931/
-----------------------------------------------------------

(Updated Aug. 31, 2015, 12:16 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Changes
-------

Submitted with commit 71c495d5b530e19d4e996b7309cc7ee392cb34be by Martin Gräßlin to \
branch master.

Repository: plasma-workspace

Description
-------

This fixes type errors shown on startup:
TypeError: Cannot read property 'showPassword' of undefined
TypeError: Cannot read property 'ButtonLabel' of undefined

Diffs
-----

  lookandfeel/contents/lockscreen/LockScreen.qml \
4ce9a001efc2ffab2d78388e3a619d0de93f1758 

Diff: https://git.reviewboard.kde.org/r/124931/diff/

Testing
-------

run kscreenlocker_greet --testing. Error no longer shown, items's still working

Thanks,

Martin Gräßlin

--===============6890486227507698115==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124931/">https://git.reviewboard.kde.org/r/124931/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Aug. 31, 2015, 12:16 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 71c495d5b530e19d4e996b7309cc7ee392cb34be by Martin \
Gräßlin to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">This fixes type errors shown on startup:
TypeError: Cannot read property &#39;showPassword&#39; of undefined
TypeError: Cannot read property &#39;ButtonLabel&#39; of undefined</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">run kscreenlocker_greet --testing. Error no longer \
shown, items's still working</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>lookandfeel/contents/lockscreen/LockScreen.qml <span style="color: \
grey">(4ce9a001efc2ffab2d78388e3a619d0de93f1758)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124931/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6890486227507698115==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 