From kde-panel-devel Mon Aug 31 12:16:06 2015 From: =?utf-8?q?Martin_Gr=C3=A4=C3=9Flin?= Date: Mon, 31 Aug 2015 12:16:06 +0000 To: kde-panel-devel Subject: Re: Review Request 124931: [lookandfeel] Fix errors on startup of lockscreen greeter Message-Id: <20150831121606.10622.43219 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=144102340525782 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7888207030099324258==" --===============7888207030099324258== Content-Type: multipart/alternative; boundary="===============6890486227507698115==" --===============6890486227507698115== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124931/ ----------------------------------------------------------- (Updated Aug. 31, 2015, 12:16 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Changes ------- Submitted with commit 71c495d5b530e19d4e996b7309cc7ee392cb34be by Martin Gräßlin to branch master. Repository: plasma-workspace Description ------- This fixes type errors shown on startup: TypeError: Cannot read property 'showPassword' of undefined TypeError: Cannot read property 'ButtonLabel' of undefined Diffs ----- lookandfeel/contents/lockscreen/LockScreen.qml 4ce9a001efc2ffab2d78388e3a619d0de93f1758 Diff: https://git.reviewboard.kde.org/r/124931/diff/ Testing ------- run kscreenlocker_greet --testing. Error no longer shown, items's still working Thanks, Martin Gräßlin --===============6890486227507698115== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124931/

This change has been marked as submitted.

Review request for Plasma.

By Martin Gräßlin.

Updated Aug. 31, 2015, 12:16 p.m.

Changes

Submitted with commit 71c495d5b530e19d4e996b7309cc7ee392cb34be by Martin Gräßlin to branch master.

Repository: plasma-workspace

Description

This fixes type errors shown on startup:
TypeError: Cannot read property 'showPassword' of undefined
TypeError: Cannot read property 'ButtonLabel' of undefined

Testing

run kscreenlocker_greet --testing. Error no longer shown, items's still working

Diffs

lookandfeel/contents/lockscreen/LockScreen.qml (4ce9a001efc2ffab2d78388e3a619d0de93f1758)

View Diff

--===============6890486227507698115==-- --===============7888207030099324258== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============7888207030099324258==--