[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124509: Use small button for session combo
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2015-07-29 10:58:16
Message-ID: 20150729105816.4444.79922 () mimi ! kde ! org
[Download RAW message or body]
--===============6711442722151487609==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124509/
-----------------------------------------------------------
(Updated Juli 29, 2015, 10:58 vorm.)
Review request for Plasma and KDE Usability.
Changes
-------
Clarify comment
Repository: plasma-workspace
Description
-------
As discussed with the VDG since it's a more of a power user feature
Diffs (updated)
-----
lookandfeel/contents/loginmanager/Main.qml 065a115
Diff: https://git.reviewboard.kde.org/r/124509/diff/
Testing
-------
Work, I had to employ a hack to make the button stay square, and also ComboBox \
doesn't have a public API to open the popup. I tried using Plasma Menu but it doesn't \
support exclusive group and the QQC Menu cannot be told where it should open other \
than the mouse position (also why is the text field not the same height as the login \
button?)
File Attachments
----------------
Login screen
https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/cd65bb14-a5cd-4fce-b937-710b732aa0b4__sessioncombo1.png
Thanks,
Kai Uwe Broulik
--===============6711442722151487609==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124509/">https://git.reviewboard.kde.org/r/124509/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma and KDE Usability.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Juli 29, 2015, 10:58 vorm.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Clarify comment</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">As discussed with the VDG since it's a more of a power \
user feature</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Work, I had to employ a hack to make the button stay \
square, and also ComboBox doesn't have a public API to open the popup. I tried using \
Plasma Menu but it doesn't support exclusive group and the QQC Menu cannot be told \
where it should open other than the mouse position (also why is the text field not \
the same height as the login button?)</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>lookandfeel/contents/loginmanager/Main.qml <span style="color: \
grey">(065a115)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124509/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/cd65bb14-a5cd-4fce-b937-710b732aa0b4__sessioncombo1.png">Login \
screen</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6711442722151487609==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic