From kde-panel-devel Wed Jul 29 10:58:16 2015 From: "Kai Uwe Broulik" Date: Wed, 29 Jul 2015 10:58:16 +0000 To: kde-panel-devel Subject: Re: Review Request 124509: Use small button for session combo Message-Id: <20150729105816.4444.79922 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=143816751412043 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0156509885492900470==" --===============0156509885492900470== Content-Type: multipart/alternative; boundary="===============6711442722151487609==" --===============6711442722151487609== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124509/ ----------------------------------------------------------- (Updated Juli 29, 2015, 10:58 vorm.) Review request for Plasma and KDE Usability. Changes ------- Clarify comment Repository: plasma-workspace Description ------- As discussed with the VDG since it's a more of a power user feature Diffs (updated) ----- lookandfeel/contents/loginmanager/Main.qml 065a115 Diff: https://git.reviewboard.kde.org/r/124509/diff/ Testing ------- Work, I had to employ a hack to make the button stay square, and also ComboBox doesn't have a public API to open the popup. I tried using Plasma Menu but it doesn't support exclusive group and the QQC Menu cannot be told where it should open other than the mouse position (also why is the text field not the same height as the login button?) File Attachments ---------------- Login screen https://git.reviewboard.kde.org/media/uploaded/files/2015/07/28/cd65bb14-a5cd-4fce-b937-710b732aa0b4__sessioncombo1.png Thanks, Kai Uwe Broulik --===============6711442722151487609== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124509/

Review request for Plasma and KDE Usability.

By Kai Uwe Broulik.

Updated Juli 29, 2015, 10:58 vorm.

Changes

Clarify comment

Repository: plasma-workspace

Description

As discussed with the VDG since it's a more of a power user feature

Testing

Work, I had to employ a hack to make the button stay square, and also ComboBox doesn't have a public API to open the popup. I tried using Plasma Menu but it doesn't support exclusive group and the QQC Menu cannot be told where it should open other than the mouse position (also why is the text field not the same height as the login button?)

Diffs (updated)

lookandfeel/contents/loginmanager/Main.qml (065a115)

View Diff

File Attachments

--===============6711442722151487609==-- --===============0156509885492900470== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============0156509885492900470==--