[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124397: Add today button to calendar
From: "Bernhard Friedreich" <friesoft () gmail ! com>
Date: 2015-07-19 20:53:54
Message-ID: 20150719205354.6735.48336 () mimi ! kde ! org
[Download RAW message or body]
--===============6426746312828078907==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Juli 19, 2015, 7:59 nachm., Kai Uwe Broulik wrote:
> > +1 from my side
> >
> > Looking really nice, I wonder why I didn't think of this earlier :)
thanks :) I'll wait for your patches to land and then rebase/push :)
- Bernhard
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124397/#review82663
-----------------------------------------------------------
On Juli 19, 2015, 5:06 nachm., Bernhard Friedreich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124397/
> -----------------------------------------------------------
>
> (Updated Juli 19, 2015, 5:06 nachm.)
>
>
> Review request for KDE Frameworks and Plasma.
>
>
> Bugs: 348362
> http://bugs.kde.org/show_bug.cgi?id=348362
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> Add button "Select Today" to calendar title bar, aligned to the right
> Removed commented out code to jump to a specific date, this will likely
> be replaced by RR 122488
>
> BUG: 348362
>
>
> Diffs
> -----
>
> src/declarativeimports/calendar/qml/MonthView.qml \
> 601755f4e9f99618914099e35616e71c332ec7c4
> Diff: https://git.reviewboard.kde.org/r/124397/diff/
>
>
> Testing
> -------
>
> plasmoidviewer with digitalclock plasmoid
> added digitalclock plasmoid to desktop
>
> clicked digital clock plasmoid to view calendar
> "Select Today" button is shown
> clicked different day
> clicked button -> jumps to today
> moved to another month -> clicked button --> jumps to today
>
>
> File Attachments
> ----------------
>
> Plasmoidviewer Digital Clock showing Calendar with Today ToolButton
> https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/edbebbc8-7e06-4edb-98c8-0df5f7f98b27__calendar_today_button.png
>
>
> Thanks,
>
> Bernhard Friedreich
>
>
--===============6426746312828078907==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124397/">https://git.reviewboard.kde.org/r/124397/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On Juli 19th, 2015, 7:59 nachm. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">+1 from my side</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Looking really nice, I wonder why I didn't think of this earlier \
:)</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">thanks :) I'll wait for your patches to land and then rebase/push \
:)</p></pre> <br />
<p>- Bernhard</p>
<br />
<p>On Juli 19th, 2015, 5:06 nachm. UTC, Bernhard Friedreich wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Bernhard Friedreich.</div>
<p style="color: grey;"><i>Updated Juli 19, 2015, 5:06 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=348362">348362</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add button "Select Today" to calendar title bar, aligned to \
the right Removed commented out code to jump to a specific date, this will likely
be replaced by RR 122488
BUG: 348362</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">plasmoidviewer with digitalclock plasmoid added \
digitalclock plasmoid to desktop</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">clicked digital clock \
plasmoid to view calendar "Select Today" button is shown
clicked different day
clicked button -> jumps to today
moved to another month -> clicked button --> jumps to today</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/calendar/qml/MonthView.qml <span style="color: \
grey">(601755f4e9f99618914099e35616e71c332ec7c4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124397/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/edbebbc8-7e06-4edb-98c8-0df5f7f98b27__calendar_today_button.png">Plasmoidviewer \
Digital Clock showing Calendar with Today ToolButton</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============6426746312828078907==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic