[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 124397: Add today button to calendar
From: "Bernhard Friedreich" <friesoft () gmail ! com>
Date: 2015-07-28 20:21:43
Message-ID: 20150728202143.21923.81462 () mimi ! kde ! org
[Download RAW message or body]
--===============7167186158222297197==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124397/
-----------------------------------------------------------
(Updated Juli 28, 2015, 8:21 nachm.)
Review request for KDE Frameworks and Plasma.
Changes
-------
Updated patch for latest calendar changes
Bugs: 348362
http://bugs.kde.org/show_bug.cgi?id=348362
Repository: plasma-framework
Description (updated)
-------
Add button "Select Today" to calendar title bar
Button only changes current view (day, month, year), not the selection
BUG: 348362
Diffs (updated)
-----
src/declarativeimports/calendar/qml/DaysCalendar.qml \
35a1e202ced1c050479ed04d71d8976a4e03a12c
Diff: https://git.reviewboard.kde.org/r/124397/diff/
Testing (updated)
-------
plasmoidviewer with digitalclock plasmoid
added digitalclock plasmoid to desktop
clicked digital clock plasmoid to view calendar
"Select Today" button is shown
select different day
clicked button -> selection changes to today
moved to another month/month selection/year/year selection -> clicked button --> \
jumps to today
File Attachments
----------------
Plasmoidviewer Digital Clock showing Calendar with Today ToolButton
https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/edbebbc8-7e06-4edb-98c8-0df5f7f98b27__calendar_today_button.png
Thanks,
Bernhard Friedreich
--===============7167186158222297197==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124397/">https://git.reviewboard.kde.org/r/124397/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Bernhard Friedreich.</div>
<p style="color: grey;"><i>Updated Juli 28, 2015, 8:21 nachm.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Updated patch for latest calendar changes</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=348362">348362</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Add button "Select Today" to calendar title bar</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Button only changes current view (day, month, year), not the selection</p> \
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">BUG: 348362</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">plasmoidviewer with digitalclock plasmoid added \
digitalclock plasmoid to desktop</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">clicked digital clock \
plasmoid to view calendar "Select Today" button is shown
select different day
clicked button -> selection changes to today
moved to another month/month selection/year/year selection -> clicked button \
--> jumps to today</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/calendar/qml/DaysCalendar.qml <span style="color: \
grey">(35a1e202ced1c050479ed04d71d8976a4e03a12c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124397/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/19/edbebbc8-7e06-4edb-98c8-0df5f7f98b27__calendar_today_button.png">Plasmoidviewer \
Digital Clock showing Calendar with Today ToolButton</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7167186158222297197==--
[Attachment #3 (text/plain)]
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic