[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124204: Use proper relative paths to import js code
From: "Marco Martin" <notmart () gmail ! com>
Date: 2015-07-01 14:08:08
Message-ID: 20150701140808.7067.58579 () mimi ! kde ! org
[Download RAW message or body]
--===============3771436061402652328==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124204/#review81947
-----------------------------------------------------------
if that qml file is only supposed to be used in a plasmoid import "code.js" should \
just work as the qqmlurlinterceptor kicks in and uses package to \
resolve.
../code/package.js is fine as well
- Marco Martin
On June 29, 2015, 7:15 a.m., Kevin Ottens wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124204/
> -----------------------------------------------------------
>
> (Updated June 29, 2015, 7:15 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: bluedevil
>
>
> Description
> -------
>
> Use proper relative paths to import js code
>
>
> Diffs
> -----
>
> src/applet/package/contents/ui/BluetoothApplet.qml \
> 4e8b9648983edd2c8db242515464ae22d1e6fbe6 \
> src/applet/package/contents/ui/CompactRepresentation.qml \
> 7085a7ec82fa88cb2d8e1a58847215845f3d5658
> Diff: https://git.reviewboard.kde.org/r/124204/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kevin Ottens
>
>
--===============3771436061402652328==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124204/">https://git.reviewboard.kde.org/r/124204/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">if \
that qml file is only supposed to be used in a plasmoid import "code.js" should just \
work as the qqmlurlinterceptor kicks in and uses package to resolve.
../code/package.js is fine as well</p></pre>
<br />
<p>- Marco Martin</p>
<br />
<p>On June 29th, 2015, 7:15 a.m. UTC, Kevin Ottens wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kevin Ottens.</div>
<p style="color: grey;"><i>Updated June 29, 2015, 7:15 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
bluedevil
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use proper relative paths to import js code</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/applet/package/contents/ui/BluetoothApplet.qml <span style="color: \
grey">(4e8b9648983edd2c8db242515464ae22d1e6fbe6)</span></li>
<li>src/applet/package/contents/ui/CompactRepresentation.qml <span style="color: \
grey">(7085a7ec82fa88cb2d8e1a58847215845f3d5658)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124204/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3771436061402652328==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic