[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124204: Use proper relative paths to import js code
From: "Kevin Ottens" <ervin () kde ! org>
Date: 2015-07-01 11:38:46
Message-ID: 20150701113846.7067.50205 () mimi ! kde ! org
[Download RAW message or body]
--===============5644236989359356675==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On June 29, 2015, 7:57 a.m., David Edmundson wrote:
> > Was this causing an error?
>
> Kevin Ottens wrote:
> Yes, most of the applets (see my other patches) were broken after my update this \
> week-end. I didn't update in a while previously. I noted that the applets were \
> inconsistent some using import "foo.js" (all broken for me) and some using import \
> "../code/foo.js" (all working for me).
> Because of the inconsistency I went on making it consistent again picking the one \
> which worked in practice.
> Note I'm testing with Qt 5.5 on my end.
>
> David Edmundson wrote:
> I have Qt5.5 here too; though maybe a month old.
>
> I'd rather we have some idea why it works for some and not your case, otherwise we \
> have a risk that our 3rd party applets/existing stable releases are going to \
> suddenly break and we'll have ignored the advanced warning.
> From what I can tell in PackageUrlInterceptor, when it tries searching for any \
> relative URL inside something loaded from a package, it will look in every \
> contentsPrefixPaths() i.e each registered folder in a plasma package structure; ui, \
> code, config for that filename.
> see packageurlinterceptor:127 it's not just for package:// urls.
>
> I don't understand why we do that, seems a bit weird to me, but we should keep \
> compatibility if we've had that in previous releases.
> I'll update my Qt to see if that changes anything.
>
> David Edmundson wrote:
> Upgrade finished, still working without the patch needed.
>
> I'm building latest Qt 5.5 of everything, is that what you were using?
>
> Kevin Ottens wrote:
> I did a rebuild of everything and my qt5 repo is on the 5.5.0 branch (there might \
> be differences between 5.5 and 5.5.0 branches ATM, hence why I point this out).
Of course I updated it all together.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124204/#review81844
-----------------------------------------------------------
On June 29, 2015, 7:15 a.m., Kevin Ottens wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124204/
> -----------------------------------------------------------
>
> (Updated June 29, 2015, 7:15 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: bluedevil
>
>
> Description
> -------
>
> Use proper relative paths to import js code
>
>
> Diffs
> -----
>
> src/applet/package/contents/ui/BluetoothApplet.qml \
> 4e8b9648983edd2c8db242515464ae22d1e6fbe6 \
> src/applet/package/contents/ui/CompactRepresentation.qml \
> 7085a7ec82fa88cb2d8e1a58847215845f3d5658
> Diff: https://git.reviewboard.kde.org/r/124204/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kevin Ottens
>
>
--===============5644236989359356675==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124204/">https://git.reviewboard.kde.org/r/124204/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 29th, 2015, 7:57 a.m. UTC, <b>David \
Edmundson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Was this causing an error?</p></pre> </blockquote>
<p>On June 29th, 2015, 8:48 a.m. UTC, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, \
most of the applets (see my other patches) were broken after my update this week-end. \
I didn't update in a while previously. I noted that the applets were inconsistent \
some using import "foo.js" (all broken for me) and some using import "../code/foo.js" \
(all working for me).</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Because of the inconsistency I went on \
making it consistent again picking the one which worked in practice.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Note I'm testing with Qt 5.5 on my end.</p></pre> </blockquote>
<p>On June 30th, 2015, 5:36 p.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
have Qt5.5 here too; though maybe a month old.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd \
rather we have some idea why it works for some and not your case, otherwise we have a \
risk that our 3rd party applets/existing stable releases are going to suddenly break \
and we'll have ignored the advanced warning.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">From what I can tell in \
PackageUrlInterceptor, when it tries searching for any relative URL inside something \
loaded from a package, it will look in every contentsPrefixPaths() i.e each \
registered folder in a plasma package structure; ui, code, config for that filename. \
</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">see packageurlinterceptor:127 it's not just for \
package:// urls.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I don't understand why we do that, \
seems a bit weird to me, but we should keep compatibility if we've had that in \
previous releases.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">I'll update my Qt to see if that \
changes anything.</p></pre> </blockquote>
<p>On July 1st, 2015, 10:28 a.m. UTC, <b>David Edmundson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Upgrade finished, still working without the patch needed.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">I'm building latest Qt 5.5 of everything, is that what you were \
using?</p></pre> </blockquote>
<p>On July 1st, 2015, 11:38 a.m. UTC, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I did \
a rebuild of everything and my qt5 repo is on the 5.5.0 branch (there might be \
differences between 5.5 and 5.5.0 branches ATM, hence why I point this \
out).</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Of \
course I updated it all together.</p></pre> <br />
<p>- Kevin</p>
<br />
<p>On June 29th, 2015, 7:15 a.m. UTC, Kevin Ottens wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kevin Ottens.</div>
<p style="color: grey;"><i>Updated June 29, 2015, 7:15 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
bluedevil
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use proper relative paths to import js code</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/applet/package/contents/ui/BluetoothApplet.qml <span style="color: \
grey">(4e8b9648983edd2c8db242515464ae22d1e6fbe6)</span></li>
<li>src/applet/package/contents/ui/CompactRepresentation.qml <span style="color: \
grey">(7085a7ec82fa88cb2d8e1a58847215845f3d5658)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124204/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5644236989359356675==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic