[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 124191: Ensure configure-time X11 path lookup is found
From: "Bhushan Shah" <bhush94 () gmail ! com>
Date: 2015-06-27 15:59:20
Message-ID: 20150627155920.20764.57573 () mimi ! kde ! org
[Download RAW message or body]
--===============3768497068325026307==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124191/#review81814
-----------------------------------------------------------
f70d8407cd3e7858e37660afd404b7b89db2ec1b breaks things it seems, \
https://bugs.kde.org/show_bug.cgi?id=349658
- Bhushan Shah
On June 27, 2015, 7:42 a.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124191/
> -----------------------------------------------------------
>
> (Updated June 27, 2015, 7:42 a.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> I just rebooted and my keyboard wasn't working. After investigating a bit, I \
> realized it was because Rules::readRules was unable to find evdev.xml. The lookup \
> is done at configure-time and I think it's better to fail it works than to \
> eventually realize it can't work.
>
> Diffs
> -----
>
> ConfigureChecks.cmake 34390d1
>
> Diff: https://git.reviewboard.kde.org/r/124191/diff/
>
>
> Testing
> -------
>
> I changed the path locally and fixed the issue.
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
--===============3768497068325026307==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124191/">https://git.reviewboard.kde.org/r/124191/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">f70d8407cd3e7858e37660afd404b7b89db2ec1b breaks things it seems, \
https://bugs.kde.org/show_bug.cgi?id=349658</p></pre> <br />
<p>- Bhushan Shah</p>
<br />
<p>On June 27th, 2015, 7:42 a.m. IST, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated June 27, 2015, 7:42 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I just rebooted and my keyboard wasn't working. After \
investigating a bit, I realized it was because Rules::readRules was unable to find \
evdev.xml. The lookup is done at configure-time and I think it's better to fail it \
works than to eventually realize it can't work.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I changed the path locally and fixed the \
issue.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ConfigureChecks.cmake <span style="color: grey">(34390d1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124191/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3768497068325026307==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic