From kde-panel-devel Sat Jun 27 15:59:20 2015 From: "Bhushan Shah" Date: Sat, 27 Jun 2015 15:59:20 +0000 To: kde-panel-devel Subject: Re: Review Request 124191: Ensure configure-time X11 path lookup is found Message-Id: <20150627155920.20764.57573 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=143542078414477 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0931248058099248977==" --===============0931248058099248977== Content-Type: multipart/alternative; boundary="===============3768497068325026307==" --===============3768497068325026307== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124191/#review81814 ----------------------------------------------------------- f70d8407cd3e7858e37660afd404b7b89db2ec1b breaks things it seems, https://bugs.kde.org/show_bug.cgi?id=349658 - Bhushan Shah On June 27, 2015, 7:42 a.m., Aleix Pol Gonzalez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124191/ > ----------------------------------------------------------- > > (Updated June 27, 2015, 7:42 a.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > I just rebooted and my keyboard wasn't working. After investigating a bit, I realized it was because Rules::readRules was unable to find evdev.xml. The lookup is done at configure-time and I think it's better to fail it works than to eventually realize it can't work. > > > Diffs > ----- > > ConfigureChecks.cmake 34390d1 > > Diff: https://git.reviewboard.kde.org/r/124191/diff/ > > > Testing > ------- > > I changed the path locally and fixed the issue. > > > Thanks, > > Aleix Pol Gonzalez > > --===============3768497068325026307== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124191/

f70d8407cd3e7858e37660afd404b7b89db2ec1b breaks things it seems, https://bugs.kde.org/show_bug.cgi?id=349658

- Bhushan Shah

On June 27th, 2015, 7:42 a.m. IST, Aleix Pol Gonzalez wrote:

Review request for Plasma.

By Aleix Pol Gonzalez.

Updated June 27, 2015, 7:42 a.m.

Repository: plasma-desktop

Description

I just rebooted and my keyboard wasn't working. After investigating a bit, I realized it was because Rules::readRules was unable to find evdev.xml. The lookup is done at configure-time and I think it's better to fail it works than to eventually realize it can't work.

Testing

I changed the path locally and fixed the issue.

Diffs

ConfigureChecks.cmake (34390d1)

View Diff

--===============3768497068325026307==-- --===============0931248058099248977== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============0931248058099248977==--