'Re: Review Request 123736: single QQmlEngine for all applets'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123736: single QQmlEngine for all applets
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2015-06-10 16:41:53
Message-ID: 20150610164153.21202.91919 () mimi ! kde ! org
[Download RAW message or body]

--===============3409755515703207971==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123736/
-----------------------------------------------------------

(Updated June 10, 2015, 4:41 p.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks and Plasma.

Changes
-------

Submitted with commit 13bd6703c0dce6694ec0f06e8a3408cd3495ab29 by Marco Martin to \
branch master.

Repository: plasma-framework

Description
-------

use a single shared QQmlEngine for all applets, tooltip and wallpapers (each of which \
used to use an own one) views are still separed engines because being View subclass \
of QQuickView which api unfortunately requires it (a qquickengine can be passed to \
the ctor, but in that case they would share their QQmlContext, which wouldn't work)

For compatibility, applets without X-Plasma-RequiredExtensions=LaunchApp will still \
have own engine

Diffs
-----

  src/declarativeimports/core/tooltipdialog.cpp feeacc3 
  src/plasmaquick/appletquickitem.cpp c6fcf22 
  src/plasmaquick/packageurlinterceptor.h 36c85a9 
  src/plasmaquick/packageurlinterceptor.cpp 5f77c3a 
  src/plasmaquick/private/appletquickitem_p.h a1ec683 
  src/scriptengines/qml/plasmoid/wallpaperinterface.cpp fcaca4b 

Diff: https://git.reviewboard.kde.org/r/123736/diff/

Testing
-------

Thanks,

Marco Martin

--===============3409755515703207971==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123736/">https://git.reviewboard.kde.org/r/123736/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Marco Martin.</div>

<p style="color: grey;"><i>Updated June 10, 2015, 4:41 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 13bd6703c0dce6694ec0f06e8a3408cd3495ab29 by Marco \
Martin to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">use a single shared QQmlEngine for all applets, \
tooltip and wallpapers (each of which used to use an own one) views are still separed \
engines because being View subclass of QQuickView which api unfortunately requires it \
(a qquickengine can be passed to the ctor, but in that case they would share their \
QQmlContext, which wouldn't work)</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">For compatibility, \
applets without X-Plasma-RequiredExtensions=LaunchApp will still have own \
engine</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/declarativeimports/core/tooltipdialog.cpp <span style="color: \
grey">(feeacc3)</span></li>

 <li>src/plasmaquick/appletquickitem.cpp <span style="color: \
grey">(c6fcf22)</span></li>

 <li>src/plasmaquick/packageurlinterceptor.h <span style="color: \
grey">(36c85a9)</span></li>

 <li>src/plasmaquick/packageurlinterceptor.cpp <span style="color: \
grey">(5f77c3a)</span></li>

 <li>src/plasmaquick/private/appletquickitem_p.h <span style="color: \
grey">(a1ec683)</span></li>

 <li>src/scriptengines/qml/plasmoid/wallpaperinterface.cpp <span style="color: \
grey">(fcaca4b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123736/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3409755515703207971==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 