[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123735: version of QmlObject with a static engine
From: "Marco Martin" <notmart () gmail ! com>
Date: 2015-06-10 16:41:39
Message-ID: 20150610164139.21202.42025 () mimi ! kde ! org
[Download RAW message or body]
--===============4393104872434977067==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123735/
-----------------------------------------------------------
(Updated June 10, 2015, 4:41 p.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
-------
Submitted with commit 5f7909408e30869980552b9d74ded57a4f8a6621 by Marco Martin to \
branch master.
Repository: kdeclarative
Description
-------
to make easier doing applications like plasma that use a lot of qml to have a single \
engine make a subclass of QmlObject called QmlObjectSharedEngine that has a single, \
static QQmlEngine
Adds a class called QuickViewSharedEngine that has the same behavior as \
QmlObjectSharedEngine(using it): static QQmlEngine, separed rootContexts() for each \
instance. This is used by desktopviews and panelviews to share their engine.
Unfortunately it may not be possible to get the applet configuration dialogs to use \
this, since they still need a separed engine in order to have a different controls \
style (qstyle based) than the stuff in the desktop/panel
Diffs
-----
autotests/CMakeLists.txt adc1102
autotests/quickviewsharedengine.cpp PRE-CREATION
autotests/util.h PRE-CREATION
autotests/util.cpp PRE-CREATION
src/kdeclarative/CMakeLists.txt d73bff0
src/kdeclarative/kdeclarative.cpp b3906e2
src/kdeclarative/qmlobject.h f26b67d
src/kdeclarative/qmlobject.cpp c483665
src/kdeclarative/qmlobjectsharedengine.h PRE-CREATION
src/kdeclarative/qmlobjectsharedengine.cpp PRE-CREATION
src/quickaddons/CMakeLists.txt 777d07c
src/quickaddons/quickviewsharedengine.h PRE-CREATION
src/quickaddons/quickviewsharedengine.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/123735/diff/
Testing
-------
Thanks,
Marco Martin
--===============4393104872434977067==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123735/">https://git.reviewboard.kde.org/r/123735/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated June 10, 2015, 4:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 5f7909408e30869980552b9d74ded57a4f8a6621 by Marco \
Martin to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeclarative
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">to make easier doing applications like plasma that use \
a lot of qml to have a single engine make a subclass of QmlObject called \
QmlObjectSharedEngine that has a single, static QQmlEngine</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Adds \
a class called QuickViewSharedEngine that has the same behavior as \
QmlObjectSharedEngine(using it): static QQmlEngine, separed rootContexts() for each \
instance. This is used by desktopviews and panelviews to share their engine.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Unfortunately it may not be possible to get the applet \
configuration dialogs to use this, since they still need a separed engine in order to \
have a different controls style (qstyle based) than the stuff in the \
desktop/panel</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: grey">(adc1102)</span></li>
<li>autotests/quickviewsharedengine.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>autotests/util.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/util.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kdeclarative/CMakeLists.txt <span style="color: grey">(d73bff0)</span></li>
<li>src/kdeclarative/kdeclarative.cpp <span style="color: \
grey">(b3906e2)</span></li>
<li>src/kdeclarative/qmlobject.h <span style="color: grey">(f26b67d)</span></li>
<li>src/kdeclarative/qmlobject.cpp <span style="color: grey">(c483665)</span></li>
<li>src/kdeclarative/qmlobjectsharedengine.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/kdeclarative/qmlobjectsharedengine.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/quickaddons/CMakeLists.txt <span style="color: grey">(777d07c)</span></li>
<li>src/quickaddons/quickviewsharedengine.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/quickaddons/quickviewsharedengine.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123735/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4393104872434977067==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic