'Re: Review Request 123923: Reuse the existing Notify method for Notification's DataEngine createNoti'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123923: Reuse the existing Notify method for Notification's DataEngine createNoti
From:       "Martin Klapetek" <martin.klapetek () gmail ! com>
Date:       2015-05-28 15:33:56
Message-ID: 20150528153356.31615.59142 () mimi ! kde ! org
[Download RAW message or body]

--===============8347673897194155034==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123923/
-----------------------------------------------------------

(Updated May 28, 2015, 3:33 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Changes
-------

Submitted with commit a12bb76502952749c069b9ab70ac61ee1353079b by Martin Klapetek to \
branch Plasma/5.3.

Repository: plasma-workspace

Description
-------

This puts the notifications coming from the Jobs applet through the same routines as \
normal notifications, including proper parsing and escaping and stuff.

This also fixes bug 342605

Diffs
-----

  applets/notifications/package/contents/ui/Jobs.qml 3307d38 
  applets/notifications/package/contents/ui/Notifications.qml 333f5b8 
  dataengines/notifications/notificationaction.cpp db27cb3 
  dataengines/notifications/notifications.operations 93b7f0c 
  dataengines/notifications/notificationsengine.h d8507d0 
  dataengines/notifications/notificationsengine.cpp 37a11dd 

Diff: https://git.reviewboard.kde.org/r/123923/diff/

Testing
-------

Copy files, notification appears correctly, is closed correctly and everything works \
as expected.

Thanks,

Martin Klapetek

--===============8347673897194155034==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123923/">https://git.reviewboard.kde.org/r/123923/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Klapetek.</div>

<p style="color: grey;"><i>Updated May 28, 2015, 3:33 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit a12bb76502952749c069b9ab70ac61ee1353079b by Martin \
Klapetek to branch Plasma/5.3.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This puts the notifications coming from the Jobs \
applet through the same routines as normal notifications, including proper parsing \
and escaping and stuff.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">This also fixes bug 342605</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Copy files, notification appears correctly, is closed \
correctly and everything works as expected.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/notifications/package/contents/ui/Jobs.qml <span style="color: \
grey">(3307d38)</span></li>

 <li>applets/notifications/package/contents/ui/Notifications.qml <span style="color: \
grey">(333f5b8)</span></li>

 <li>dataengines/notifications/notificationaction.cpp <span style="color: \
grey">(db27cb3)</span></li>

 <li>dataengines/notifications/notifications.operations <span style="color: \
grey">(93b7f0c)</span></li>

 <li>dataengines/notifications/notificationsengine.h <span style="color: \
grey">(d8507d0)</span></li>

 <li>dataengines/notifications/notificationsengine.cpp <span style="color: \
grey">(37a11dd)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123923/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8347673897194155034==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 