--===============1820672122206366805== Content-Type: multipart/alternative; boundary="===============8347673897194155034==" --===============8347673897194155034== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123923/ ----------------------------------------------------------- (Updated May 28, 2015, 3:33 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Changes ------- Submitted with commit a12bb76502952749c069b9ab70ac61ee1353079b by Martin Klapetek to branch Plasma/5.3. Repository: plasma-workspace Description ------- This puts the notifications coming from the Jobs applet through the same routines as normal notifications, including proper parsing and escaping and stuff. This also fixes bug 342605 Diffs ----- applets/notifications/package/contents/ui/Jobs.qml 3307d38 applets/notifications/package/contents/ui/Notifications.qml 333f5b8 dataengines/notifications/notificationaction.cpp db27cb3 dataengines/notifications/notifications.operations 93b7f0c dataengines/notifications/notificationsengine.h d8507d0 dataengines/notifications/notificationsengine.cpp 37a11dd Diff: https://git.reviewboard.kde.org/r/123923/diff/ Testing ------- Copy files, notification appears correctly, is closed correctly and everything works as expected. Thanks, Martin Klapetek --===============8347673897194155034== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123923/

This change has been marked as submitted.

Review request for Plasma.
By Martin Klapetek.

Updated May 28, 2015, 3:33 p.m.

Changes

Submitted with commit a12bb76502952749c069b9ab70ac61ee1353079b by Martin Klapetek to branch Plasma/5.3.
Repository: plasma-workspace

Description 

This puts the notifications coming from the Jobs applet through the same routines as normal notifications, including proper parsing and escaping and stuff.


This also fixes bug 342605

Testing 

Copy files, notification appears correctly, is closed correctly and everything works as expected.

Diffs

  • applets/notifications/package/contents/ui/Jobs.qml (3307d38)
  • applets/notifications/package/contents/ui/Notifications.qml (333f5b8)
  • dataengines/notifications/notificationaction.cpp (db27cb3)
  • dataengines/notifications/notifications.operations (93b7f0c)
  • dataengines/notifications/notificationsengine.h (d8507d0)
  • dataengines/notifications/notificationsengine.cpp (37a11dd)

View Diff
--===============8347673897194155034==-- --===============1820672122206366805== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============1820672122206366805==--