[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123731: Cleanup handling of notifications closing
From: "Martin Klapetek" <martin.klapetek () gmail ! com>
Date: 2015-05-25 8:23:40
Message-ID: 20150525082340.17589.40900 () mimi ! kde ! org
[Download RAW message or body]
--===============2679391636443088778==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123731/
-----------------------------------------------------------
(Updated May 25, 2015, 8:23 a.m.)
Status
------
This change has been marked as submitted.
Review request for KDE Frameworks and Plasma.
Changes
-------
Submitted with commit 35900a84a8e7de77747031c3ba26ed1ac61f389f by Martin Klapetek to \
branch master.
Repository: knotifications
Description
-------
While investigating the cause of crash of https://bugs.kde.org/show_bug.cgi?id=342752 \
I've come across some loose ends in how KNotifications is handling closing of \
notifications.
As for the crash itself, I never managed to reproduce even with special written test \
cases, but what happens (or seem to) is this:
* KNotification object gets deleted
* The destructor calls close() on all plugins
* The NotifyByPopup plugin does async dbus call to close the notification and \
returns
* KNotification's dpointer is deleted
* The DBus reply returns, calling NotifyByPopup::finished()
* Now for some reason the KNotification object is still not null but its dpointer is \
gone, so the check "if (!notification || \
d->notifications.contains(notification->id()))" crashes on the notification->id() \
call
So I've made it simply return -1 when dpointer is null, which should ideally prevent \
the crashes
Diffs
-----
src/knotification.cpp 01962b3
src/knotificationmanager.cpp 0d9b3b0
src/knotificationmanager_p.h f8e7df8
src/notifybypopup.cpp 2f84ab0
Diff: https://git.reviewboard.kde.org/r/123731/diff/
Testing
-------
Thanks,
Martin Klapetek
--===============2679391636443088778==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123731/">https://git.reviewboard.kde.org/r/123731/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated May 25, 2015, 8:23 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 35900a84a8e7de77747031c3ba26ed1ac61f389f by Martin \
Klapetek to branch master.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knotifications
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">While investigating the cause of crash of \
https://bugs.kde.org/show_bug.cgi?id=342752 I've come across some loose ends in \
how KNotifications is handling closing of notifications.
As for the crash itself, I never managed to reproduce even with special written test \
cases, but what happens (or seem to) is this:
* KNotification object gets deleted
* The destructor calls close() on all plugins
* The NotifyByPopup plugin does async dbus call to close the notification and \
returns
* KNotification's dpointer is deleted
* The DBus reply returns, calling NotifyByPopup::finished()
* Now for some reason the KNotification object is still not null but its dpointer is \
gone, so the check "if (!notification || \
d->notifications.contains(notification->id()))" crashes on the \
notification->id() call
So I've made it simply return -1 when dpointer is null, which should ideally \
prevent the crashes</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/knotification.cpp <span style="color: grey">(01962b3)</span></li>
<li>src/knotificationmanager.cpp <span style="color: grey">(0d9b3b0)</span></li>
<li>src/knotificationmanager_p.h <span style="color: grey">(f8e7df8)</span></li>
<li>src/notifybypopup.cpp <span style="color: grey">(2f84ab0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123731/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2679391636443088778==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic