[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123889: [krunner] Add button to clear history
From: "Vishesh Handa" <me () vhanda ! in>
Date: 2015-05-25 7:56:07
Message-ID: 20150525075607.17589.7526 () mimi ! kde ! org
[Download RAW message or body]
--===============5517609920967019165==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123889/#review80789
-----------------------------------------------------------
Ship it!
Please only ship this once the other patch is in.
kcms/runners/kcm.cpp (line 64)
<https://git.reviewboard.kde.org/r/123889/#comment55385>
Please use `KConfigGroup::deleteEntry`
- Vishesh Handa
On May 23, 2015, 10:01 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123889/
> -----------------------------------------------------------
>
> (Updated May 23, 2015, 10:01 p.m.)
>
>
> Review request for Plasma, KDE Usability and Vishesh Handa.
>
>
> Bugs: 275645?
> https://bugs.kde.org/show_bug.cgi?id=275645?
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> This adds a "Clear history" button to the plasmasearch kcm to clear the history.
>
>
> Diffs
> -----
>
> kcms/runners/kcm.cpp 10b7683
>
> Diff: https://git.reviewboard.kde.org/r/123889/diff/
>
>
> Testing
> -------
>
> Clicked button, history gone, popup updated automatically. Could perhaps check \
> whether the history is currently empty and be disabled in that case? Dunno if \
> adding a file watcher to track live changes is worth it though.
>
> File Attachments
> ----------------
>
> Button in KCM
> https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/c86950ed-04ca-4d3d-8697-a13c21b47ad6__krunnerclearhistory.png
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============5517609920967019165==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123889/">https://git.reviewboard.kde.org/r/123889/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Please only ship this once the other patch is in.</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123889/diff/1/?file=370579#file370579line64" \
style="color: black; font-weight: bold; text-decoration: \
underline;">kcms/runners/kcm.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">SearchConfigModule::SearchConfigModule(QWidget* parent, const QVariantList& \
args)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">64</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">generalConfig</span><span class="p">.</span><span \
class="n">writeEntry</span><span class="p">(</span><span \
class="s">"history"</span><span class="p">,</span> <span \
class="n">QStringList</span><span class="p">());</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Please use <code style="text-rendering: inherit;color: #4444cc;padding: \
0;white-space: normal;margin: 0;line-height: \
inherit;">KConfigGroup::deleteEntry</code></p></pre> </div>
</div>
<br />
<p>- Vishesh Handa</p>
<br />
<p>On May 23rd, 2015, 10:01 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, KDE Usability and Vishesh Handa.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated May 23, 2015, 10:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=275645?">275645?</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This adds a "Clear history" button to the plasmasearch \
kcm to clear the history.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Clicked button, history gone, popup updated \
automatically. Could perhaps check whether the history is currently empty and be \
disabled in that case? Dunno if adding a file watcher to track live changes is worth \
it though.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/runners/kcm.cpp <span style="color: grey">(10b7683)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123889/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/05/23/c86950ed-04ca-4d3d-8697-a13c21b47ad6__krunnerclearhistory.png">Button \
in KCM</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5517609920967019165==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic