'Re: Review Request 123570: Add a method to insert new known structures'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123570: Add a method to insert new known structures
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2015-04-30 9:31:12
Message-ID: 20150430093112.21733.26552 () mimi ! kde ! org
[Download RAW message or body]

--===============3113787539633972550==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123570/
-----------------------------------------------------------

(Updated April 30, 2015, 9:31 a.m.)

Review request for KDE Frameworks and Plasma.

Repository: kpackage

Description (updated)
-------

When we have internal structures that aren't plugins, loadpackage/listPackages/findPackages are \
pretty much broken, since they can't find the structure instance.

in order to load packages one can subclass packageloader, but listing still doesn't work.
this makes possible for apps to insert new structure types without having to subclass.
an alternative is an internalListPackages similar to internalLoadPackage, but i'm not too keep \
to use a packageloader subclass in libplasma, because then any user of libplasma could replace \
the packageloader again, breaking it.

or alternatively all internal plasma package types could become plugins as well (that i fear \
would become necessary at some point if we want to be able to fully replace plasmapkg2 with \
kpackagetool)

Diffs
-----

  src/kpackage/packageloader.h 4cc40e6 
  src/kpackage/packageloader.cpp 174f54b 

Diff: https://git.reviewboard.kde.org/r/123570/diff/

Testing
-------

Thanks,

Marco Martin

--===============3113787539633972550==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123570/">https://git.reviewboard.kde.org/r/123570/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Marco Martin.</div>

<p style="color: grey;"><i>Updated April 30, 2015, 9:31 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kpackage
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  (updated)</h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">When we have \
internal structures that aren't plugins, loadpackage/listPackages/findPackages are pretty much \
broken, since they can't find the structure instance.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">in order to load packages one can \
subclass packageloader, but listing still doesn't work. this makes possible for apps to insert \
new structure types without having to subclass. an alternative is an internalListPackages \
similar to internalLoadPackage, but i'm not too keep to use a packageloader subclass in \
libplasma, because then any user of libplasma could replace the packageloader again, breaking \
it.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">or alternatively all internal plasma package types could become \
plugins as well (that i fear would become necessary at some point if we want to be able to \
fully replace plasmapkg2 with kpackagetool)</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kpackage/packageloader.h <span style="color: grey">(4cc40e6)</span></li>

 <li>src/kpackage/packageloader.cpp <span style="color: grey">(174f54b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123570/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3113787539633972550==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 