--===============9080346715245279726== Content-Type: multipart/alternative; boundary="===============3113787539633972550==" --===============3113787539633972550== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123570/ ----------------------------------------------------------- (Updated April 30, 2015, 9:31 a.m.) Review request for KDE Frameworks and Plasma. Repository: kpackage Description (updated) ------- When we have internal structures that aren't plugins, loadpackage/listPackages/findPackages are pretty much broken, since they can't find the structure instance. in order to load packages one can subclass packageloader, but listing still doesn't work. this makes possible for apps to insert new structure types without having to subclass. an alternative is an internalListPackages similar to internalLoadPackage, but i'm not too keep to use a packageloader subclass in libplasma, because then any user of libplasma could replace the packageloader again, breaking it. or alternatively all internal plasma package types could become plugins as well (that i fear would become necessary at some point if we want to be able to fully replace plasmapkg2 with kpackagetool) Diffs ----- src/kpackage/packageloader.h 4cc40e6 src/kpackage/packageloader.cpp 174f54b Diff: https://git.reviewboard.kde.org/r/123570/diff/ Testing ------- Thanks, Marco Martin --===============3113787539633972550== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123570/

Review request for KDE Frameworks and Plasma.

By Marco Martin.

Updated April 30, 2015, 9:31 a.m.

Repository: kpackage

Description (updated)

When we have internal structures that aren't plugins, loadpackage/listPackages/findPackages are pretty much broken, since they can't find the structure instance.
in order to load packages one can subclass packageloader, but listing still doesn't work.
this makes possible for apps to insert new structure types without having to subclass.
an alternative is an internalListPackages similar to internalLoadPackage, but i'm not too keep to use a packageloader subclass in libplasma, because then any user of libplasma could replace the packageloader again, breaking it.
or alternatively all internal plasma package types could become plugins as well (that i fear would become necessary at some point if we want to be able to fully replace plasmapkg2 with kpackagetool)

Diffs

src/kpackage/packageloader.h (4cc40e6)
src/kpackage/packageloader.cpp (174f54b)

--===============3113787539633972550==-- --===============9080346715245279726== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============9080346715245279726==--