'Re: Review Request 123547: Task manager : New instances can now be opened by mid click.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List: kde-panel-devel
Subject: Re: Review Request 123547: Task manager : New instances can now be opened by mid click.
From: "Eike Hein" <hein () kde ! org>
Date: 2015-04-30 0:26:16
Message-ID: 20150430002616.21733.80673 () mimi ! kde ! org
[Download RAW message or body]

--===============1720986861375336534==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On April 28, 2015, 11:48 p.m., Eike Hein wrote:
> > People  frequently request either "new instance" or "close window" for middle-click, so \
> > unfortunately I think this will have to be a config option and I won't accept a patch that \
> > only implements the one behavior.
> 
> Martin Gräßlin wrote:
> Even more I would expect that it copies the current copy buffer into a running instance. \
> Middle click is paste after all. 
> Yoann Laissus wrote:
> @Eike : Ok, I'll add an option in the settings to choose between them.
> @Martin : I'm not sure to understand, what do you mean by copying the copy buffer ?
> 
> Martin Gräßlin wrote:
> Middle click normaly pastes the content of the "copy buffer" (mark with left click to copy). \
> My expected behavior would be that if e.g. I have a URL in the copy buffer and middle click a \
> Firefox launcher it will open a new tab with the URL loaded. 
> Sebastian Kügler wrote:
> That sounds like a really neat thing. Hidden, but really neat. :)
> 
> Eike Hein wrote:
> "Pass URL in clipboard as argument" could be an optional add-on behavior to "Start new \
> instance" which would get that Firefox thing going. Bit concerned with an option jungle \
> though and I fear it's too unpredictable and too likely to lead to bad results to make a \
> default ... 
> Yoann Laissus wrote:
> I think it's a very nice idea too. But as you said, Eike, it will depend a lot of the app and \
> the copied content. So having that as an option makes sense. 
> To sum up, we will have three choices for the mid button combo box :
> - Close app
> - Open new instance
> - Open new instance with clipboard content as argument
> 
> For the default one, I think it's better to have "Open new instance". "Close apps" can be \
> dangerous if users don't know the behaviour. 
> Are you ok with that ?

Let's keep it simple for now and do:

On middle-click: Do nothing (Default) / Close Window / Start New Instance

Let's hold back the clipboard thing for now and perhaps try to do it in a second patch. It \
needs some fairly careful thought and implementation, e.g. parsing %u and %U in .desktop files \
(where windows can be mapped to them) to figure out what to with single vs. multiple URLs in \
the clipboard and possibly other MIME-related considerations.

- Eike

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123547/#review79649
-----------------------------------------------------------

On April 28, 2015, 8:45 p.m., Yoann Laissus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123547/
> -----------------------------------------------------------
> 
> (Updated April 28, 2015, 8:45 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Currently, only the shortcut Shift + Left click is available.
> In KDE4, we had both.
> 
> 
> Diffs
> -----
> 
> applets/taskmanager/package/contents/ui/Task.qml f5fc723 
> 
> Diff: https://git.reviewboard.kde.org/r/123547/diff/
> 
> 
> Testing
> -------
> 
> Tested with classic task manager and the icon only one.
> Tested with all mouse button combinaisons and keyboard modifiers.
> 
> 
> Thanks,
> 
> Yoann Laissus
> 
> 

--===============1720986861375336534==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123547/">https://git.reviewboard.kde.org/r/123547/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 On April 28th, 2015, 11:48 p.m. UTC, Eike Hein wrote:
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">People frequently request either \
"new instance" or "close window" for middle-click, so unfortunately I think this will have to \
be a config option and I won't accept a patch that only implements the one behavior.</pre> \
</blockquote>

On April 29th, 2015, 5:57 a.m. UTC, Martin Gräßlin wrote:
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Even more I would expect that it \
copies the current copy buffer into a running instance. Middle click is paste after \
all.</pre> </blockquote>

On April 29th, 2015, 7:36 a.m. UTC, Yoann Laissus wrote:
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">@Eike : Ok, I'll add an option in \
the settings to choose between them. @Martin : I'm not sure to understand, what do you mean by \
copying the copy buffer ?</pre> </blockquote>

On April 29th, 2015, 7:39 a.m. UTC, Martin Gräßlin wrote:
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Middle click normaly pastes the \
content of the "copy buffer" (mark with left click to copy). My expected behavior would be that \
if e.g. I have a URL in the copy buffer and middle click a Firefox launcher it will open a new \
tab with the URL loaded.</pre> </blockquote>

On April 29th, 2015, 11:57 a.m. UTC, Sebastian Kügler wrote:
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">That sounds like a really neat \
thing. Hidden, but really neat. :)</pre> </blockquote>

On April 29th, 2015, 12:25 p.m. UTC, Eike Hein wrote:
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">"Pass URL in clipboard as \
argument" could be an optional add-on behavior to "Start new instance" which would get that \
Firefox thing going. Bit concerned with an option jungle though and I fear it's too \
unpredictable and too likely to lead to bad results to make a default ...</pre> \
</blockquote>

 <p>On April 29th, 2015, 4:22 p.m. UTC, <b>Yoann Laissus</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I think it's a very nice idea \
too. But as you said, Eike, it will depend a lot of the app and the copied content. So having \
that as an option makes sense.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">To sum up, we will have three choices for the mid \
                button combo box :
- Close app
- Open new instance
- Open new instance with clipboard content as argument</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">For the default one, I think it's better to have "Open new instance". "Close apps" \
can be dangerous if users don't know the behaviour.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Are you ok with that ?</p></pre>  \
</blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;">Let's keep it simple for now and \
do: On middle-click: Do nothing (Default) / Close Window / Start New \
Instance Let's hold back the clipboard thing for now and perhaps try to \
do it in a second patch. It needs some fairly careful thought and implementation, e.g. parsing \
%u and %U in .desktop files (where windows can be mapped to them) to figure out what to with \
single vs. multiple URLs in the clipboard and possibly other MIME-related \
considerations.</pre>

<p>- Eike</p>

<br />
<p>On April 28th, 2015, 8:45 p.m. UTC, Yoann Laissus wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Yoann Laissus.</div>

<p style="color: grey;"><i>Updated April 28, 2015, 8:45 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0"> <tr>
 <td>
 <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Currently, only \
the shortcut Shift + Left click is available. In KDE4, we had both.</pre>
 </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0"> <tr>
 <td>
 <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested with \
classic task manager and the icon only one. Tested with all mouse button combinaisons and \
keyboard modifiers.</pre> </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/taskmanager/package/contents/ui/Task.qml <span style="color: \
grey">(f5fc723)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123547/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1720986861375336534==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 