--===============1843334563900238475== Content-Type: multipart/alternative; boundary="===============1720986861375336534==" --===============1720986861375336534== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On April 28, 2015, 11:48 p.m., Eike Hein wrote: > > People frequently request either "new instance" or "close window" for middle-click, so unfortunately I think this will have to be a config option and I won't accept a patch that only implements the one behavior. > > Martin Gräßlin wrote: > Even more I would expect that it copies the current copy buffer into a running instance. Middle click is paste after all. > > Yoann Laissus wrote: > @Eike : Ok, I'll add an option in the settings to choose between them. > @Martin : I'm not sure to understand, what do you mean by copying the copy buffer ? > > Martin Gräßlin wrote: > Middle click normaly pastes the content of the "copy buffer" (mark with left click to copy). My expected behavior would be that if e.g. I have a URL in the copy buffer and middle click a Firefox launcher it will open a new tab with the URL loaded. > > Sebastian Kügler wrote: > That sounds like a really neat thing. Hidden, but really neat. :) > > Eike Hein wrote: > "Pass URL in clipboard as argument" could be an optional add-on behavior to "Start new instance" which would get that Firefox thing going. Bit concerned with an option jungle though and I fear it's too unpredictable and too likely to lead to bad results to make a default ... > > Yoann Laissus wrote: > I think it's a very nice idea too. But as you said, Eike, it will depend a lot of the app and the copied content. So having that as an option makes sense. > > To sum up, we will have three choices for the mid button combo box : > - Close app > - Open new instance > - Open new instance with clipboard content as argument > > For the default one, I think it's better to have "Open new instance". "Close apps" can be dangerous if users don't know the behaviour. > > Are you ok with that ? Let's keep it simple for now and do: On middle-click: Do nothing (Default) / Close Window / Start New Instance Let's hold back the clipboard thing for now and perhaps try to do it in a second patch. It needs some fairly careful thought and implementation, e.g. parsing %u and %U in .desktop files (where windows can be mapped to them) to figure out what to with single vs. multiple URLs in the clipboard and possibly other MIME-related considerations. - Eike ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123547/#review79649 ----------------------------------------------------------- On April 28, 2015, 8:45 p.m., Yoann Laissus wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123547/ > ----------------------------------------------------------- > > (Updated April 28, 2015, 8:45 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > Currently, only the shortcut Shift + Left click is available. > In KDE4, we had both. > > > Diffs > ----- > > applets/taskmanager/package/contents/ui/Task.qml f5fc723 > > Diff: https://git.reviewboard.kde.org/r/123547/diff/ > > > Testing > ------- > > Tested with classic task manager and the icon only one. > Tested with all mouse button combinaisons and keyboard modifiers. > > > Thanks, > > Yoann Laissus > > --===============1720986861375336534== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123547/

On April 28th, 2015, 11:48 p.m. UTC, Eike Hein wrote:

People frequently request either "new instance" or "close window" for middle-click, so unfortunately I think this will have to be a config option and I won't accept a patch that only implements the one behavior.

On April 29th, 2015, 5:57 a.m. UTC, Martin Gräßlin wrote:

Even more I would expect that it copies the current copy buffer into a running instance. Middle click is paste after all.

On April 29th, 2015, 7:36 a.m. UTC, Yoann Laissus wrote:

@Eike : Ok, I'll add an option in the settings to choose between them. @Martin : I'm not sure to understand, what do you mean by copying the copy buffer ?

On April 29th, 2015, 7:39 a.m. UTC, Martin Gräßlin wrote:

Middle click normaly pastes the content of the "copy buffer" (mark with left click to copy). My expected behavior would be that if e.g. I have a URL in the copy buffer and middle click a Firefox launcher it will open a new tab with the URL loaded.

On April 29th, 2015, 11:57 a.m. UTC, Sebastian Kügler wrote:

That sounds like a really neat thing. Hidden, but really neat. :)

On April 29th, 2015, 12:25 p.m. UTC, Eike Hein wrote:

"Pass URL in clipboard as argument" could be an optional add-on behavior to "Start new instance" which would get that Firefox thing going. Bit concerned with an option jungle though and I fear it's too unpredictable and too likely to lead to bad results to make a default ...

On April 29th, 2015, 4:22 p.m. UTC, Yoann Laissus wrote:

I think it's a very nice idea too. But as you said, Eike, it will depend a lot of the app and the copied content. So having that as an option makes sense.

To sum up, we will have three choices for the mid button combo box : - Close app - Open new instance - Open new instance with clipboard content as argument

For the default one, I think it's better to have "Open new instance". "Close apps" can be dangerous if users don't know the behaviour.

Are you ok with that ?

Let's keep it simple for now and do:

On middle-click: Do nothing (Default) / Close Window / Start New Instance

Let's hold back the clipboard thing for now and perhaps try to do it in a second patch. It needs some fairly careful thought and implementation, e.g. parsing %u and %U in .desktop files (where windows can be mapped to them) to figure out what to with single vs. multiple URLs in the clipboard and possibly other MIME-related considerations.


- Eike


On April 28th, 2015, 8:45 p.m. UTC, Yoann Laissus wrote:

Review request for Plasma.
By Yoann Laissus.

Updated April 28, 2015, 8:45 p.m.

Repository: plasma-desktop

Description

Currently, only the shortcut Shift + Left click is available. In KDE4, we had both.

Testing

Tested with classic task manager and the icon only one. Tested with all mouse button combinaisons and keyboard modifiers.

Diffs

  • applets/taskmanager/package/contents/ui/Task.qml (f5fc723)

View Diff

--===============1720986861375336534==-- --===============1843334563900238475== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============1843334563900238475==--