[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123539: Improve visibility of running widget checkmark
From: "David Edmundson" <david () davidedmundson ! co ! uk>
Date: 2015-04-28 18:48:21
Message-ID: 20150428184821.14758.61395 () mimi ! kde ! org
[Download RAW message or body]
--===============2399579048187405048==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123539/#review79642
-----------------------------------------------------------
code looks good.
desktoppackage/contents/explorer/AppletDelegate.qml (line 101)
<https://git.reviewboard.kde.org/r/123539/#comment54451>
it's a bit odd that we have background colour on top of the text highlight \
colour.
Though AFAIk that combo is always garunteed to be visible.. so meh.
desktoppackage/contents/explorer/AppletDelegate.qml (line 119)
<https://git.reviewboard.kde.org/r/123539/#comment54450>
you can also add
supportsAtlasTextures: true
as we're not tiling any of the sources.
- David Edmundson
On April 28, 2015, 6:34 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123539/
> -----------------------------------------------------------
>
> (Updated April 28, 2015, 6:34 p.m.)
>
>
> Review request for Plasma, KDE Usability and Andrew Lake.
>
>
> Bugs: 342112
> https://bugs.kde.org/show_bug.cgi?id=342112
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> As suggested by Andrew show a badge kind of thing with the number of running \
> applets inside.
>
> Diffs
> -----
>
> desktoppackage/contents/explorer/AppletDelegate.qml 2e53c1e
>
> Diff: https://git.reviewboard.kde.org/r/123539/diff/
>
>
> Testing
> -------
>
> After fixing a nasty bug in the model it shows the proper number now. It also \
> doesn't break if you happen to have 10 or more widgets of the same kind. I did not \
> know what kind of font color to use.
>
> File Attachments
> ----------------
>
> Badge in action
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/27/1b8483bb-fe3b-4701-92d3-02b437e63843__widgetexplorernumber2.jpg
> Fancy effect in action
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/28/289d6677-bb68-4b69-a43a-3becf226ad3b__badgeshader2.png
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============2399579048187405048==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123539/">https://git.reviewboard.kde.org/r/123539/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">code \
looks good.</p></pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123539/diff/2/?file=364287#file364287line103" \
style="color: black; font-weight: bold; text-decoration: \
underline;">desktoppackage/contents/explorer/AppletDelegate.qml</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">101</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">color:</span> <span class="nx">theme</span><span \
class="p">.</span><span class="nx">backgroundColor</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">it's \
a bit odd that we have background colour on top of the text highlight colour.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Though AFAIk that combo is always garunteed to be visible.. so \
meh.</p></pre> </div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123539/diff/2/?file=364287#file364287line121" \
style="color: black; font-weight: bold; text-decoration: \
underline;">desktoppackage/contents/explorer/AppletDelegate.qml</a> <span \
style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">119</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">you \
can also add </p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">supportsAtlasTextures: true</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">as \
we're not tiling any of the sources.</p></pre> </div>
</div>
<br />
<p>- David Edmundson</p>
<br />
<p>On April 28th, 2015, 6:34 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, KDE Usability and Andrew Lake.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated April 28, 2015, 6:34 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=342112">342112</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">As suggested by Andrew show a badge kind of thing with \
the number of running applets inside.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">After fixing a nasty bug in the model it shows the \
proper number now. It also doesn't break if you happen to have 10 or more widgets of \
the same kind. I did not know what kind of font color to use.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>desktoppackage/contents/explorer/AppletDelegate.qml <span style="color: \
grey">(2e53c1e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123539/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/27/1b8483bb-fe3b-4701-92d3-02b437e63843__widgetexplorernumber2.jpg">Badge \
in action</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/28/289d6677-bb68-4b69-a43a-3becf226ad3b__badgeshader2.png">Fancy \
effect in action</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============2399579048187405048==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic