[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123539: Improve visibility of running widget checkmark
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2015-04-28 18:34:45
Message-ID: 20150428183445.14758.77003 () mimi ! kde ! org
[Download RAW message or body]

--===============0774341957235767004==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123539/
-----------------------------------------------------------

(Updated April 28, 2015, 6:34 nachm.)


Review request for Plasma, KDE Usability and Andrew Lake.


Changes
-------

Eike came up with this idea:
- No inset gradient, just a solid Rectangle
- Inverted text color
- A section "cut off" from the icon

The seemingly random 1.5 is a compromise between too much of a glow and too big of a \
moat


Bugs: 342112
    https://bugs.kde.org/show_bug.cgi?id=342112


Repository: plasma-desktop


Description
-------

As suggested by Andrew show a badge kind of thing with the number of running applets \
inside.


Diffs (updated)
-----

  desktoppackage/contents/explorer/AppletDelegate.qml 2e53c1e 

Diff: https://git.reviewboard.kde.org/r/123539/diff/


Testing
-------

After fixing a nasty bug in the model it shows the proper number now. It also doesn't \
break if you happen to have 10 or more widgets of the same kind. I did not know what \
kind of font color to use.


File Attachments (updated)
----------------

Badge in action
  https://git.reviewboard.kde.org/media/uploaded/files/2015/04/27/1b8483bb-fe3b-4701-92d3-02b437e63843__widgetexplorernumber2.jpg
 Fancy effect in action
  https://git.reviewboard.kde.org/media/uploaded/files/2015/04/28/289d6677-bb68-4b69-a43a-3becf226ad3b__badgeshader2.png



Thanks,

Kai Uwe Broulik


--===============0774341957235767004==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123539/">https://git.reviewboard.kde.org/r/123539/</a>
  </td>
    </tr>
   </table>
   <br />




<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, KDE Usability and Andrew Lake.</div>
<div>By Kai Uwe Broulik.</div>


<p style="color: grey;"><i>Updated April 28, 2015, 6:34 nachm.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">Eike came up with this idea:
- No inset gradient, just a solid Rectangle
- Inverted text color
- A section &quot;cut off&quot; from the icon

The seemingly random 1.5 is a compromise between too much of a glow and too big of a \
moat</pre>  </td>
 </tr>
</table>





<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://bugs.kde.org/show_bug.cgi?id=342112">342112</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">As suggested by Andrew show a badge kind of thing with \
the number of running applets inside.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">After fixing a nasty bug in the model it shows the \
proper number now. It also doesn't break if you happen to have 10 or more widgets of \
the same kind. I did not know what kind of font color to use.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>desktoppackage/contents/explorer/AppletDelegate.qml <span style="color: \
grey">(2e53c1e)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123539/diff/" style="margin-left: \
3em;">View Diff</a></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
(updated)</h1>


 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/27/1b8483bb-fe3b-4701-92d3-02b437e63843__widgetexplorernumber2.jpg">Badge \
in action</a></li>

 <li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/28/289d6677-bb68-4b69-a43a-3becf226ad3b__badgeshader2.png">Fancy \
effect in action</a></li>

</ul>




  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============0774341957235767004==--


[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic