[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123537: Add support for menu sections
From: "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date: 2015-04-27 20:21:53
Message-ID: 20150427202153.14758.46985 () mimi ! kde ! org
[Download RAW message or body]
--===============0487799662934795882==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123537/#review79598
-----------------------------------------------------------
src/declarativeimports/plasmacomponents/qmenu.cpp (line 196)
<https://git.reviewboard.kde.org/r/123537/#comment54383>
I added an isVisible check before this (and above), so you could conditionally \
show sections using bindings, eg. so "Recent documents for" is only shown when \
documents exist.
- Kai Uwe Broulik
On April 27, 2015, 8:20 nachm., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123537/
> -----------------------------------------------------------
>
> (Updated April 27, 2015, 8:20 nachm.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-framework
>
>
> Description
> -------
>
> QMenuItem now has a "section" property that makes it behave like a section. I did \
> not find a removeSection method, however.
>
> Diffs
> -----
>
> src/declarativeimports/plasmacomponents/qmenu.h a927d12
> src/declarativeimports/plasmacomponents/qmenu.cpp 0b82a99
> src/declarativeimports/plasmacomponents/qmenuitem.h f8629f0
> src/declarativeimports/plasmacomponents/qmenuitem.cpp aa61288
> tests/components/menu.qml PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/123537/diff/
>
>
> Testing
> -------
>
> Seems to work fine, icons are not supported, comes with a manual test.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
--===============0487799662934795882==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123537/">https://git.reviewboard.kde.org/r/123537/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/123537/diff/1/?file=363796#file363796line196" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/declarativeimports/plasmacomponents/qmenu.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
QMenuProxy::itemTriggered(QAction *action)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">196</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">m_menu</span><span class="o">-></span><span \
class="n">addSection</span><span class="p">(</span><span class="n">item</span><span \
class="o">-></span><span class="n">text</span><span \
class="p">());</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
added an isVisible check before this (and above), so you could conditionally show \
sections using bindings, eg. so "Recent documents for" is only shown when documents \
exist.</p></pre> </div>
</div>
<br />
<p>- Kai Uwe Broulik</p>
<br />
<p>On April 27th, 2015, 8:20 nachm. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated April 27, 2015, 8:20 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">QMenuItem now has a "section" property that makes it \
behave like a section. I did not find a removeSection method, however.</p></pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Seems to work fine, icons are not supported, comes \
with a manual test.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/declarativeimports/plasmacomponents/qmenu.h <span style="color: \
grey">(a927d12)</span></li>
<li>src/declarativeimports/plasmacomponents/qmenu.cpp <span style="color: \
grey">(0b82a99)</span></li>
<li>src/declarativeimports/plasmacomponents/qmenuitem.h <span style="color: \
grey">(f8629f0)</span></li>
<li>src/declarativeimports/plasmacomponents/qmenuitem.cpp <span style="color: \
grey">(aa61288)</span></li>
<li>tests/components/menu.qml <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123537/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============0487799662934795882==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic