'Re: Review Request 123537: Add support for menu sections'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123537: Add support for menu sections
From:       "Kai Uwe Broulik" <kde () privat ! broulik ! de>
Date:       2015-04-27 20:20:20
Message-ID: 20150427202020.14758.62953 () mimi ! kde ! org
[Download RAW message or body]

--===============0907976446579042132==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123537/
-----------------------------------------------------------

(Updated April 27, 2015, 8:20 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Changes
-------

Submitted with commit 93cf07deac366888fa7e8a06fe7593c1d5a92505 by Kai Uwe Broulik to \
branch master.

Repository: plasma-framework

Description
-------

QMenuItem now has a "section" property that makes it behave like a section. I did not \
find a removeSection method, however.

Diffs
-----

  src/declarativeimports/plasmacomponents/qmenu.h a927d12 
  src/declarativeimports/plasmacomponents/qmenu.cpp 0b82a99 
  src/declarativeimports/plasmacomponents/qmenuitem.h f8629f0 
  src/declarativeimports/plasmacomponents/qmenuitem.cpp aa61288 
  tests/components/menu.qml PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/123537/diff/

Testing
-------

Seems to work fine, icons are not supported, comes with a manual test.

Thanks,

Kai Uwe Broulik

--===============0907976446579042132==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123537/">https://git.reviewboard.kde.org/r/123537/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated April 27, 2015, 8:20 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 93cf07deac366888fa7e8a06fe7593c1d5a92505 by Kai \
Uwe Broulik to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-framework
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">QMenuItem now has a "section" property that makes it \
behave like a section. I did not find a removeSection method, however.</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Seems to work fine, icons are not supported, comes \
with a manual test.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/declarativeimports/plasmacomponents/qmenu.h <span style="color: \
grey">(a927d12)</span></li>

 <li>src/declarativeimports/plasmacomponents/qmenu.cpp <span style="color: \
grey">(0b82a99)</span></li>

 <li>src/declarativeimports/plasmacomponents/qmenuitem.h <span style="color: \
grey">(f8629f0)</span></li>

 <li>src/declarativeimports/plasmacomponents/qmenuitem.cpp <span style="color: \
grey">(aa61288)</span></li>

 <li>tests/components/menu.qml <span style="color: grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123537/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0907976446579042132==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 