'Re: Review Request 123493: Fix leaky incubation controller'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123493: Fix leaky incubation controller
From:       "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date:       2015-04-25 0:30:42
Message-ID: 20150425003042.5446.44818 () mimi ! kde ! org
[Download RAW message or body]

--===============2197622194626465551==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123493/#review79481
-----------------------------------------------------------

Ship it!

Ship It!

- Aleix Pol Gonzalez

On April 24, 2015, 6:43 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123493/
> -----------------------------------------------------------
> 
> (Updated April 24, 2015, 6:43 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> Docs for QQmlEngine explcitly say
> 
> "The engine can only have one active controller and it does not take
> ownership of it." therefore we need to set a parent.
> 
> The incubator controls the deletion of generated objects, so this means we're \
> leaking all QML items created by the KDeclarative::QmlObject. 
> 
> Diffs
> -----
> 
> src/kdeclarative/qmlobject.cpp c483665c43985ba57459a880895ee8bf7ff92041 
> 
> Diff: https://git.reviewboard.kde.org/r/123493/diff/
> 
> 
> Testing
> -------
> 
> Plasma shell still loads and runs fine. Valgrind is a lot less angry.
> Will merge after 5.10 to play safe.
> 
> 
> Thanks,
> 
> David Edmundson
> 
> 

--===============2197622194626465551==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123493/">https://git.reviewboard.kde.org/r/123493/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Aleix Pol Gonzalez</p>

<br />
<p>On April 24th, 2015, 6:43 p.m. CEST, David Edmundson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Plasma.</div>
<div>By David Edmundson.</div>

<p style="color: grey;"><i>Updated April 24, 2015, 6:43 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeclarative
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Docs for QQmlEngine explcitly say</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">"The engine can only have one active controller and it does not take \
ownership of it." therefore we need to set a parent.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The \
incubator controls the deletion of generated objects, so this means we're leaking all \
QML items created by the KDeclarative::QmlObject.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Plasma shell still loads and runs fine. Valgrind is a \
lot less angry. Will merge after 5.10 to play safe.</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kdeclarative/qmlobject.cpp <span style="color: \
grey">(c483665c43985ba57459a880895ee8bf7ff92041)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123493/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2197622194626465551==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 