From kde-panel-devel Sat Apr 25 00:30:42 2015 From: "Aleix Pol Gonzalez" Date: Sat, 25 Apr 2015 00:30:42 +0000 To: kde-panel-devel Subject: Re: Review Request 123493: Fix leaky incubation controller Message-Id: <20150425003042.5446.44818 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=142992186720678 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7117192905337929471==" --===============7117192905337929471== Content-Type: multipart/alternative; boundary="===============2197622194626465551==" --===============2197622194626465551== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123493/#review79481 ----------------------------------------------------------- Ship it! Ship It! - Aleix Pol Gonzalez On April 24, 2015, 6:43 p.m., David Edmundson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123493/ > ----------------------------------------------------------- > > (Updated April 24, 2015, 6:43 p.m.) > > > Review request for KDE Frameworks and Plasma. > > > Repository: kdeclarative > > > Description > ------- > > Docs for QQmlEngine explcitly say > > "The engine can only have one active controller and it does not take > ownership of it." therefore we need to set a parent. > > The incubator controls the deletion of generated objects, so this means we're leaking all QML items created by the KDeclarative::QmlObject. > > > Diffs > ----- > > src/kdeclarative/qmlobject.cpp c483665c43985ba57459a880895ee8bf7ff92041 > > Diff: https://git.reviewboard.kde.org/r/123493/diff/ > > > Testing > ------- > > Plasma shell still loads and runs fine. Valgrind is a lot less angry. > Will merge after 5.10 to play safe. > > > Thanks, > > David Edmundson > > --===============2197622194626465551== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123493/

Ship it!

Ship It!

- Aleix Pol Gonzalez

On April 24th, 2015, 6:43 p.m. CEST, David Edmundson wrote:

Review request for KDE Frameworks and Plasma.

By David Edmundson.

Updated April 24, 2015, 6:43 p.m.

Repository: kdeclarative

Description

Docs for QQmlEngine explcitly say

"The engine can only have one active controller and it does not take ownership of it." therefore we need to set a parent.

The incubator controls the deletion of generated objects, so this means we're leaking all QML items created by the KDeclarative::QmlObject.

Testing

Plasma shell still loads and runs fine. Valgrind is a lot less angry. Will merge after 5.10 to play safe.

Diffs

src/kdeclarative/qmlobject.cpp (c483665c43985ba57459a880895ee8bf7ff92041)

View Diff

--===============2197622194626465551==-- --===============7117192905337929471== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============7117192905337929471==--