[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123473: Port mouse theme kcm to QML
From: "Marco Martin" <notmart () gmail ! com>
Date: 2015-04-23 14:25:30
Message-ID: 20150423142530.839.28608 () mimi ! kde ! org
[Download RAW message or body]
--===============3011518213165782281==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On April 23, 2015, 11:31 a.m., Eike Hein wrote:
> > > This is more an experiment on how much modules can be closely ported (and in \
> > > how much time).
> >
> > What's the benefit to the user of merging this version now?
>
> Marco Martin wrote:
> none.
> not too much pain as well tough.
> all of them have to eventually be ported tough and in order to get done, one has \
> to.. do it
> Eike Hein wrote:
> > all of them have to eventually be ported tough and in order to get done, one has \
> > to.. do it
>
> I'm just not a big fan of putting transitional pain (worse UI from a weaker \
> toolkit) on the user when there's an opportunity to avoid it, I guess ... right \
> now, Qt Quick has worse performance, no keyboard accelerator management, no form \
> layouts, limited widgets, some visual problems, etc. - It's true of course that \
> using it builds greater pressure to get it fixed, but are we *certain* that \
> actively hurting the quality of our releases is the only path available?
bah, right now accelerators and tab focus kinda works in that module..
still kinda, but again, if the decision is to go in that direction, of which i \
remeber it was talked about and decided, otherwise I wouldn't have wasted two days on \
it ;) Now, I'm fine if now we decide to not port modules, but most of them kindof \
have to be redone anyways, and I would prefer reding them once rather than twice.
- Marco
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123473/#review79374
-----------------------------------------------------------
On April 23, 2015, 2:08 p.m., Marco Martin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123473/
> -----------------------------------------------------------
>
> (Updated April 23, 2015, 2:08 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> This is more an experiment on how much modules can be closely ported (and in how \
> much time). the mouse theme kcm should be pretty much feature complete.
> the main problem is the size combobox missing the cursor image due to the \
> QtQuickControls ComboBox being very limited and without a customizable delegate. \
> all the other functions such as add/remove/ghns seems to work well
>
> Diffs
> -----
>
> applets/icontasks/metadata.desktop f0b237c
> containments/folder/metadata.desktop a6d08a7
> kcms/access/kcmaccess.desktop 825b6d7
> kcms/baloo/kcm_baloofile.desktop 2eee6fc
> kcms/cursortheme/CMakeLists.txt 83f3ba2
> kcms/cursortheme/Messages.sh 79450c7
> kcms/cursortheme/cursortheme.desktop f443208
> kcms/cursortheme/kcm_cursortheme.desktop PRE-CREATION
> kcms/cursortheme/kcmcursortheme.h d9e32b2
> kcms/cursortheme/kcmcursortheme.cpp 44576ff
> kcms/cursortheme/package/contents/ui/Delegate.qml PRE-CREATION
> kcms/cursortheme/package/contents/ui/main.qml PRE-CREATION
> kcms/cursortheme/package/metadata.desktop PRE-CREATION
> kcms/cursortheme/xcursor/itemdelegate.h 9acb0e9
> kcms/cursortheme/xcursor/itemdelegate.cpp e737005
> kcms/cursortheme/xcursor/previewwidget.h 4a11e2d
> kcms/cursortheme/xcursor/previewwidget.cpp 79d1305
> kcms/cursortheme/xcursor/sortproxymodel.h 95c9646
> kcms/cursortheme/xcursor/sortproxymodel.cpp b9d6309
> kcms/cursortheme/xcursor/thememodel.h bcf046a
> kcms/cursortheme/xcursor/thememodel.cpp 4e4647f
> kcms/cursortheme/xcursor/themepage.h 98c69fd
> kcms/cursortheme/xcursor/themepage.cpp 687bd65
> kcms/cursortheme/xcursor/themepage.ui 6efe60b
> kcms/desktoppaths/desktoppath.desktop eb2fad5
> kcms/lookandfeel/autotests/lookandfeel/metadata.desktop 3360a85
> kcms/lookandfeel/kcm_lookandfeel.desktop 8550e5c
> kcms/lookandfeel/package/metadata.desktop 6595d6e
> kcms/touchpad/src/applet/qml/metadata.desktop e9a0bc1
> kcms/touchpad/src/kcm/kcm_touchpad.desktop c537e5f
> kcms/touchpad/src/kded/kcm_touchpad.notifyrc 9e51e0e
> kcms/touchpad/src/kded/kded_touchpad.desktop ec076a9
> kcms/useraccount/kcm_useraccount.desktop 46ef110
> layout-templates/org.kde.plasma.desktop.defaultPanel/metadata.desktop 89d7fc3
>
> Diff: https://git.reviewboard.kde.org/r/123473/diff/
>
>
> Testing
> -------
>
>
> File Attachments
> ----------------
>
> cursorskcm.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png
>
>
> Thanks,
>
> Marco Martin
>
>
--===============3011518213165782281==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123473/">https://git.reviewboard.kde.org/r/123473/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 23rd, 2015, 11:31 a.m. UTC, <b>Eike \
Hein</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 \
1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: \
inherit;"> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is more an experiment on how much modules can be \
closely ported (and in how much time).</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">What's the benefit to the user of merging this version \
now?</p></pre> </blockquote>
<p>On April 23rd, 2015, 11:35 a.m. UTC, <b>Marco Martin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">none. \
not too much pain as well tough. all of them have to eventually be ported tough and \
in order to get done, one has to.. do it</p></pre> </blockquote>
<p>On April 23rd, 2015, 11:47 a.m. UTC, <b>Eike Hein</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote \
style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid \
#bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;"> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">all of them have to eventually be ported tough and in order to get done, \
one has to.. do it</p> </blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I'm just not a big fan of putting transitional pain \
(worse UI from a weaker toolkit) on the user when there's an opportunity to avoid it, \
I guess ... right now, Qt Quick has worse performance, no keyboard accelerator \
management, no form layouts, limited widgets, some visual problems, etc. - It's true \
of course that using it builds greater pressure to get it fixed, but are we <em \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
normal;">certain</em> that actively hurting the quality of our releases is the only \
path available?</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">bah, \
right now accelerators and tab focus kinda works in that module.. still kinda, but \
again, if the decision is to go in that direction, of which i remeber it was talked \
about and decided, otherwise I wouldn't have wasted two days on it ;) Now, I'm fine \
if now we decide to not port modules, but most of them kindof have to be redone \
anyways, and I would prefer reding them once rather than twice.</p></pre> <br />
<p>- Marco</p>
<br />
<p>On April 23rd, 2015, 2:08 p.m. UTC, Marco Martin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Marco Martin.</div>
<p style="color: grey;"><i>Updated April 23, 2015, 2:08 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is more an experiment on how much modules can be \
closely ported (and in how much time). the mouse theme kcm should be pretty much \
feature complete. the main problem is the size combobox missing the cursor image due \
to the QtQuickControls ComboBox being very limited and without a customizable \
delegate. all the other functions such as add/remove/ghns seems to work \
well</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>applets/icontasks/metadata.desktop <span style="color: \
grey">(f0b237c)</span></li>
<li>containments/folder/metadata.desktop <span style="color: \
grey">(a6d08a7)</span></li>
<li>kcms/access/kcmaccess.desktop <span style="color: grey">(825b6d7)</span></li>
<li>kcms/baloo/kcm_baloofile.desktop <span style="color: grey">(2eee6fc)</span></li>
<li>kcms/cursortheme/CMakeLists.txt <span style="color: grey">(83f3ba2)</span></li>
<li>kcms/cursortheme/Messages.sh <span style="color: grey">(79450c7)</span></li>
<li>kcms/cursortheme/cursortheme.desktop <span style="color: \
grey">(f443208)</span></li>
<li>kcms/cursortheme/kcm_cursortheme.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kcms/cursortheme/kcmcursortheme.h <span style="color: \
grey">(d9e32b2)</span></li>
<li>kcms/cursortheme/kcmcursortheme.cpp <span style="color: \
grey">(44576ff)</span></li>
<li>kcms/cursortheme/package/contents/ui/Delegate.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kcms/cursortheme/package/contents/ui/main.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kcms/cursortheme/package/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>kcms/cursortheme/xcursor/itemdelegate.h <span style="color: \
grey">(9acb0e9)</span></li>
<li>kcms/cursortheme/xcursor/itemdelegate.cpp <span style="color: \
grey">(e737005)</span></li>
<li>kcms/cursortheme/xcursor/previewwidget.h <span style="color: \
grey">(4a11e2d)</span></li>
<li>kcms/cursortheme/xcursor/previewwidget.cpp <span style="color: \
grey">(79d1305)</span></li>
<li>kcms/cursortheme/xcursor/sortproxymodel.h <span style="color: \
grey">(95c9646)</span></li>
<li>kcms/cursortheme/xcursor/sortproxymodel.cpp <span style="color: \
grey">(b9d6309)</span></li>
<li>kcms/cursortheme/xcursor/thememodel.h <span style="color: \
grey">(bcf046a)</span></li>
<li>kcms/cursortheme/xcursor/thememodel.cpp <span style="color: \
grey">(4e4647f)</span></li>
<li>kcms/cursortheme/xcursor/themepage.h <span style="color: \
grey">(98c69fd)</span></li>
<li>kcms/cursortheme/xcursor/themepage.cpp <span style="color: \
grey">(687bd65)</span></li>
<li>kcms/cursortheme/xcursor/themepage.ui <span style="color: \
grey">(6efe60b)</span></li>
<li>kcms/desktoppaths/desktoppath.desktop <span style="color: \
grey">(eb2fad5)</span></li>
<li>kcms/lookandfeel/autotests/lookandfeel/metadata.desktop <span style="color: \
grey">(3360a85)</span></li>
<li>kcms/lookandfeel/kcm_lookandfeel.desktop <span style="color: \
grey">(8550e5c)</span></li>
<li>kcms/lookandfeel/package/metadata.desktop <span style="color: \
grey">(6595d6e)</span></li>
<li>kcms/touchpad/src/applet/qml/metadata.desktop <span style="color: \
grey">(e9a0bc1)</span></li>
<li>kcms/touchpad/src/kcm/kcm_touchpad.desktop <span style="color: \
grey">(c537e5f)</span></li>
<li>kcms/touchpad/src/kded/kcm_touchpad.notifyrc <span style="color: \
grey">(9e51e0e)</span></li>
<li>kcms/touchpad/src/kded/kded_touchpad.desktop <span style="color: \
grey">(ec076a9)</span></li>
<li>kcms/useraccount/kcm_useraccount.desktop <span style="color: \
grey">(46ef110)</span></li>
<li>layout-templates/org.kde.plasma.desktop.defaultPanel/metadata.desktop <span \
style="color: grey">(89d7fc3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123473/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/04/23/72f14417-e14c-4385-9e8e-959dd1f2d8e4__cursorskcm.png">cursorskcm.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3011518213165782281==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic