[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123467: Add CoverArt uri to the metadata exposed with MPRIS interfaces
From:       "Ashish Madeti" <ashishmadeti () gmail ! com>
Date:       2015-04-23 14:20:38
Message-ID: 20150423142038.5446.10269 () mimi ! kde ! org
[Download RAW message or body]

--===============8205256984894299677==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123467/
-----------------------------------------------------------

(Updated April 23, 2015, 2:20 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, Bhushan Shah, Sebastian Kügler, Shantanu Tushar, and \
Sinny Kumari.


Changes
-------

Submitted with commit 8c416587adc8780639d3bef02c16a198f58b16f7 by Ashish Madeti to \
branch master.


Repository: plasma-mediacenter


Description
-------

Save Cover art to a temporary folder. Include the path of the cover art in the \
metadata currently exposed with MPRIS interfaces.


Diffs
-----

  libs/mediacenter/mpris2/mpris2.cpp f03d062 

Diff: https://git.reviewboard.kde.org/r/123467/diff/


Testing
-------

Correct path is showing up in the metadata when tested with mpristester.
Correct cover art is showing up in the mpris controller (appearing in system tray) of \
Plasma 5.


Thanks,

Ashish Madeti


--===============8205256984894299677==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit




<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123467/">https://git.reviewboard.kde.org/r/123467/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma, Bhushan Shah, Sebastian Kügler, Shantanu Tushar, and \
Sinny Kumari.</div> <div>By Ashish Madeti.</div>


<p style="color: grey;"><i>Updated April 23, 2015, 2:20 p.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 8c416587adc8780639d3bef02c16a198f58b16f7 by Ashish \
Madeti to branch master.</pre>  </td>
 </tr>
</table>







<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-mediacenter
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Save Cover art to a temporary folder. Include the path \
of the cover art in the metadata currently exposed with MPRIS interfaces.</p></pre>  \
</td>  </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Correct path is showing up in the metadata when tested \
with mpristester. Correct cover art is showing up in the mpris controller (appearing \
in system tray) of Plasma 5.</p></pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/mediacenter/mpris2/mpris2.cpp <span style="color: \
grey">(f03d062)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123467/diff/" style="margin-left: \
3em;">View Diff</a></p>






  </td>
 </tr>
</table>



  </div>
 </body>
</html>


--===============8205256984894299677==--


[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic