'Re: Review Request 123190: CMakeLists.txt: Install sddm theme to KDE_INSTALL_DATADIR'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123190: CMakeLists.txt: Install sddm theme to KDE_INSTALL_DATADIR
From:       "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date:       2015-03-31 23:43:31
Message-ID: 20150331234331.26405.94056 () mimi ! kde ! org
[Download RAW message or body]

--===============0078512488114084681==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

> On March 31, 2015, 8:02 p.m., David Edmundson wrote:
> > this is arch independent?

Wrong question ;). You meant to say "is this platform independent?". And the answer is: Yes, \
it's a variable defined within KDEInstallDirs so that each platform can do as they please.

- Aleix

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123190/#review78293
-----------------------------------------------------------

On March 31, 2015, 2:02 a.m., Heiko Becker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123190/
> -----------------------------------------------------------
> 
> (Updated March 31, 2015, 2:02 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This allows installing the sddm theme to a datadir which is outside of the prefix, for \
> example on a multiarch layout where arch specific stuff goes to /usr/${host}/blah but arch \
> independent stuff still to /usr/share. 
> 
> Diffs
> -----
> 
> CMakeLists.txt 40350b2 
> 
> Diff: https://git.reviewboard.kde.org/r/123190/diff/
> 
> 
> Testing
> -------
> 
> Built and installed to the configured location.
> 
> 
> Thanks,
> 
> Heiko Becker
> 
> 

--===============0078512488114084681==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123190/">https://git.reviewboard.kde.org/r/123190/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On March 31st, 2015, 8:02 p.m. CEST, <b>David Edmundson</b> \
wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">this is arch \
independent?</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; \
white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Wrong question ;). You meant to \
say "is this platform independent?". And the answer is: Yes, it's a variable defined within \
KDEInstallDirs so that each platform can do as they please.</p></pre> <br />

<p>- Aleix</p>

<br />
<p>On March 31st, 2015, 2:02 a.m. CEST, Heiko Becker wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px \
#888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Heiko Becker.</div>

<p style="color: grey;"><i>Updated March 31, 2015, 2:02 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This allows \
installing the sddm theme to a datadir which is outside of the prefix, for example on a \
multiarch layout where arch specific stuff goes to /usr/${host}/blah but arch independent stuff \
still to /usr/share.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Built and installed \
to the configured location.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>CMakeLists.txt <span style="color: grey">(40350b2)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123190/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0078512488114084681==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 