From kde-panel-devel Tue Mar 31 23:43:31 2015 From: "Aleix Pol Gonzalez" Date: Tue, 31 Mar 2015 23:43:31 +0000 To: kde-panel-devel Subject: Re: Review Request 123190: CMakeLists.txt: Install sddm theme to KDE_INSTALL_DATADIR Message-Id: <20150331234331.26405.94056 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=142784547201049 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============6134276396836102933==" --===============6134276396836102933== Content-Type: multipart/alternative; boundary="===============0078512488114084681==" --===============0078512488114084681== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On March 31, 2015, 8:02 p.m., David Edmundson wrote: > > this is arch independent? Wrong question ;). You meant to say "is this platform independent?". And the answer is: Yes, it's a variable defined within KDEInstallDirs so that each platform can do as they please. - Aleix ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123190/#review78293 ----------------------------------------------------------- On March 31, 2015, 2:02 a.m., Heiko Becker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123190/ > ----------------------------------------------------------- > > (Updated March 31, 2015, 2:02 a.m.) > > > Review request for Plasma. > > > Repository: plasma-workspace > > > Description > ------- > > This allows installing the sddm theme to a datadir which is outside of the prefix, for example on a multiarch layout where arch specific stuff goes to /usr/${host}/blah but arch independent stuff still to /usr/share. > > > Diffs > ----- > > CMakeLists.txt 40350b2 > > Diff: https://git.reviewboard.kde.org/r/123190/diff/ > > > Testing > ------- > > Built and installed to the configured location. > > > Thanks, > > Heiko Becker > > --===============0078512488114084681== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123190/

On March 31st, 2015, 8:02 p.m. CEST, David Edmundson wrote:
this is arch independent?

Wrong question ;). You meant to say "is this platform independent?". And the answer is: Yes, it's a variable defined within KDEInstallDirs so that each platform can do as they please.

- Aleix

On March 31st, 2015, 2:02 a.m. CEST, Heiko Becker wrote:

Review request for Plasma.

By Heiko Becker.

Updated March 31, 2015, 2:02 a.m.

Repository: plasma-workspace

Description

This allows installing the sddm theme to a datadir which is outside of the prefix, for example on a multiarch layout where arch specific stuff goes to /usr/${host}/blah but arch independent stuff still to /usr/share.

Testing

Built and installed to the configured location.

Diffs

CMakeLists.txt (40350b2)

View Diff

--===============0078512488114084681==-- --===============6134276396836102933== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============6134276396836102933==--