[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 123164: Add new Bluetooth applet
From: "David Rosca" <nowrep () gmail ! com>
Date: 2015-03-31 11:55:58
Message-ID: 20150331115558.26405.41036 () mimi ! kde ! org
[Download RAW message or body]
--===============1282026459291513411==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On March 29, 2015, 6 p.m., Kai Uwe Broulik wrote:
> > File Attachment: snapshot4.png - snapshot4.png
> > <https://git.reviewboard.kde.org/r/123164/#fcomment387>
> >
> > Perhaps give the button a text, one could easily miss it.
It doesn't look good with the text: \
http://wstaw.org/m/2015/03/31/plasma-desktopJYg879.png
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123164/#review78179
-----------------------------------------------------------
On March 31, 2015, 9:22 a.m., David Rosca wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123164/
> -----------------------------------------------------------
>
> (Updated March 31, 2015, 9:22 a.m.)
>
>
> Review request for Bluedevil and Plasma.
>
>
> Repository: bluedevil
>
>
> Description
> -------
>
> This is a replacement for bluedevil-monolithic.
> The code is based on network management plasmoid and it does basically the same but \
> for Bluetooth devices.
>
> Diffs
> -----
>
> CMakeLists.txt 94b56fb
> src/CMakeLists.txt b804f2b
> src/applet/CMakeLists.txt PRE-CREATION
> src/applet/Messages.sh PRE-CREATION
> src/applet/package/contents/code/logic.js PRE-CREATION
> src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION
> src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION
> src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION
> src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION
> src/applet/package/contents/ui/Header.qml PRE-CREATION
> src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION
> src/applet/package/contents/ui/Toolbar.qml PRE-CREATION
> src/applet/package/metadata.desktop PRE-CREATION
> src/applet/plugin/CMakeLists.txt PRE-CREATION
> src/applet/plugin/bluetoothplugin.h PRE-CREATION
> src/applet/plugin/bluetoothplugin.cpp PRE-CREATION
> src/applet/plugin/devicesproxymodel.h PRE-CREATION
> src/applet/plugin/devicesproxymodel.cpp PRE-CREATION
> src/applet/plugin/launchapp.h PRE-CREATION
> src/applet/plugin/launchapp.cpp PRE-CREATION
> src/applet/plugin/notify.h PRE-CREATION
> src/applet/plugin/notify.cpp PRE-CREATION
> src/applet/plugin/qmldir PRE-CREATION
> src/bluedevil.notifyrc f87dc95
>
> Diff: https://git.reviewboard.kde.org/r/123164/diff/
>
>
> Testing
> -------
>
> I've been running it for some time already and it works fine.
>
>
> File Attachments
> ----------------
>
> snapshot4.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png
> snapshot5.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png
> btapplet6.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/31/d8ffae3d-f4f4-4bf1-b5ad-27d1298d4d3f__btapplet6.png
> btapplet7.png
> https://git.reviewboard.kde.org/media/uploaded/files/2015/03/31/957074cc-acf4-40b1-bb08-857ac6937669__btapplet7.png
>
>
> Thanks,
>
> David Rosca
>
>
--===============1282026459291513411==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123164/">https://git.reviewboard.kde.org/r/123164/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 29th, 2015, 6 p.m. UTC, <b>Kai Uwe \
Broulik</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding: 0 0 0 1em;">
<br style="display: none;" />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid \
#c0c0c0; margin-bottom: 10px"> <tr>
<td>
<a href="https://git.reviewboard.kde.org/r/123164/file/1977/" style="color: \
black; font-weight: bold; font-size: 9pt;">snapshot4.png</a>
<p>snapshot4.png</p>
</td>
</tr>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Perhaps give the button \
a text, one could easily miss it.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">It doesn't look good with the text: \
http://wstaw.org/m/2015/03/31/plasma-desktopJYg879.png</p></pre> <br />
<p>- David</p>
<br />
<p>On March 31st, 2015, 9:22 a.m. UTC, David Rosca wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Bluedevil and Plasma.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated March 31, 2015, 9:22 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
bluedevil
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is a replacement for bluedevil-monolithic. The \
code is based on network management plasmoid and it does basically the same but for \
Bluetooth devices.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I've been running it for some time already and it \
works fine.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(94b56fb)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(b804f2b)</span></li>
<li>src/applet/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/applet/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/applet/package/contents/code/logic.js <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/package/contents/ui/BluetoothApplet.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/package/contents/ui/CompactRepresentation.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/package/contents/ui/DeviceItem.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/package/contents/ui/FullRepresentation.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/package/contents/ui/Header.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/package/contents/ui/SwitchButton.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/package/contents/ui/Toolbar.qml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/package/metadata.desktop <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/plugin/CMakeLists.txt <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/plugin/bluetoothplugin.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/plugin/bluetoothplugin.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/plugin/devicesproxymodel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/plugin/devicesproxymodel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/plugin/launchapp.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/plugin/launchapp.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/plugin/notify.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/applet/plugin/notify.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>src/applet/plugin/qmldir <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/bluedevil.notifyrc <span style="color: grey">(f87dc95)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123164/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png">snapshot4.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png">snapshot5.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/03/31/d8ffae3d-f4f4-4bf1-b5ad-27d1298d4d3f__btapplet6.png">btapplet6.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/03/31/957074cc-acf4-40b1-bb08-857ac6937669__btapplet7.png">btapplet7.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1282026459291513411==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic