From kde-panel-devel Tue Mar 31 11:55:58 2015 From: "David Rosca" Date: Tue, 31 Mar 2015 11:55:58 +0000 To: kde-panel-devel Subject: Re: Review Request 123164: Add new Bluetooth applet Message-Id: <20150331115558.26405.41036 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=142780298018346 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2739585375020457193==" --===============2739585375020457193== Content-Type: multipart/alternative; boundary="===============1282026459291513411==" --===============1282026459291513411== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On March 29, 2015, 6 p.m., Kai Uwe Broulik wrote: > > File Attachment: snapshot4.png - snapshot4.png > > > > > > Perhaps give the button a text, one could easily miss it. It doesn't look good with the text: http://wstaw.org/m/2015/03/31/plasma-desktopJYg879.png - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123164/#review78179 ----------------------------------------------------------- On March 31, 2015, 9:22 a.m., David Rosca wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123164/ > ----------------------------------------------------------- > > (Updated March 31, 2015, 9:22 a.m.) > > > Review request for Bluedevil and Plasma. > > > Repository: bluedevil > > > Description > ------- > > This is a replacement for bluedevil-monolithic. > The code is based on network management plasmoid and it does basically the same but for Bluetooth devices. > > > Diffs > ----- > > CMakeLists.txt 94b56fb > src/CMakeLists.txt b804f2b > src/applet/CMakeLists.txt PRE-CREATION > src/applet/Messages.sh PRE-CREATION > src/applet/package/contents/code/logic.js PRE-CREATION > src/applet/package/contents/ui/BluetoothApplet.qml PRE-CREATION > src/applet/package/contents/ui/CompactRepresentation.qml PRE-CREATION > src/applet/package/contents/ui/DeviceItem.qml PRE-CREATION > src/applet/package/contents/ui/FullRepresentation.qml PRE-CREATION > src/applet/package/contents/ui/Header.qml PRE-CREATION > src/applet/package/contents/ui/SwitchButton.qml PRE-CREATION > src/applet/package/contents/ui/Toolbar.qml PRE-CREATION > src/applet/package/metadata.desktop PRE-CREATION > src/applet/plugin/CMakeLists.txt PRE-CREATION > src/applet/plugin/bluetoothplugin.h PRE-CREATION > src/applet/plugin/bluetoothplugin.cpp PRE-CREATION > src/applet/plugin/devicesproxymodel.h PRE-CREATION > src/applet/plugin/devicesproxymodel.cpp PRE-CREATION > src/applet/plugin/launchapp.h PRE-CREATION > src/applet/plugin/launchapp.cpp PRE-CREATION > src/applet/plugin/notify.h PRE-CREATION > src/applet/plugin/notify.cpp PRE-CREATION > src/applet/plugin/qmldir PRE-CREATION > src/bluedevil.notifyrc f87dc95 > > Diff: https://git.reviewboard.kde.org/r/123164/diff/ > > > Testing > ------- > > I've been running it for some time already and it works fine. > > > File Attachments > ---------------- > > snapshot4.png > https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/acba4387-a4e7-4e77-830d-91dc5ed5c574__snapshot4.png > snapshot5.png > https://git.reviewboard.kde.org/media/uploaded/files/2015/03/28/d0cab8ca-a62b-4672-9600-cbd61de25c63__snapshot5.png > btapplet6.png > https://git.reviewboard.kde.org/media/uploaded/files/2015/03/31/d8ffae3d-f4f4-4bf1-b5ad-27d1298d4d3f__btapplet6.png > btapplet7.png > https://git.reviewboard.kde.org/media/uploaded/files/2015/03/31/957074cc-acf4-40b1-bb08-857ac6937669__btapplet7.png > > > Thanks, > > David Rosca > > --===============1282026459291513411== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123164/

On March 29th, 2015, 6 p.m. UTC, Kai Uwe Broulik wrote:
snapshot4.png
snapshot4.png
Perhaps give the button a text, one could easily miss it.

It doesn't look good with the text: http://wstaw.org/m/2015/03/31/plasma-desktopJYg879.png

- David

On March 31st, 2015, 9:22 a.m. UTC, David Rosca wrote:

Review request for Bluedevil and Plasma.

By David Rosca.

Updated March 31, 2015, 9:22 a.m.

Repository: bluedevil

Description

This is a replacement for bluedevil-monolithic. The code is based on network management plasmoid and it does basically the same but for Bluetooth devices.

Testing

I've been running it for some time already and it works fine.

Diffs

CMakeLists.txt (94b56fb)
src/CMakeLists.txt (b804f2b)
src/applet/CMakeLists.txt (PRE-CREATION)
src/applet/Messages.sh (PRE-CREATION)
src/applet/package/contents/code/logic.js (PRE-CREATION)
src/applet/package/contents/ui/BluetoothApplet.qml (PRE-CREATION)
src/applet/package/contents/ui/CompactRepresentation.qml (PRE-CREATION)
src/applet/package/contents/ui/DeviceItem.qml (PRE-CREATION)
src/applet/package/contents/ui/FullRepresentation.qml (PRE-CREATION)
src/applet/package/contents/ui/Header.qml (PRE-CREATION)
src/applet/package/contents/ui/SwitchButton.qml (PRE-CREATION)
src/applet/package/contents/ui/Toolbar.qml (PRE-CREATION)
src/applet/package/metadata.desktop (PRE-CREATION)
src/applet/plugin/CMakeLists.txt (PRE-CREATION)
src/applet/plugin/bluetoothplugin.h (PRE-CREATION)
src/applet/plugin/bluetoothplugin.cpp (PRE-CREATION)
src/applet/plugin/devicesproxymodel.h (PRE-CREATION)
src/applet/plugin/devicesproxymodel.cpp (PRE-CREATION)
src/applet/plugin/launchapp.h (PRE-CREATION)
src/applet/plugin/launchapp.cpp (PRE-CREATION)
src/applet/plugin/notify.h (PRE-CREATION)
src/applet/plugin/notify.cpp (PRE-CREATION)
src/applet/plugin/qmldir (PRE-CREATION)
src/bluedevil.notifyrc (f87dc95)

File Attachments

--===============1282026459291513411==-- --===============2739585375020457193== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============2739585375020457193==--