'Re: Review Request 123161: Add copy and paste support for calculator widget'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123161: Add copy and paste support for calculator widget
From:       "Bernhard Friedreich" <friesoft () gmail ! com>
Date:       2015-03-28 15:18:03
Message-ID: 20150328151803.17385.53831 () mimi ! kde ! org
[Download RAW message or body]

--===============6246933957315662925==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123161/
-----------------------------------------------------------

(Updated March 28, 2015, 3:18 p.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Changes
-------

Submitted with commit 16cad20c28e09109844f1e34ae87c71ae8259350 by David Edmundson on \
behalf of Bernhard Friedreich to branch master.

Bugs: 318221
    http://bugs.kde.org/show_bug.cgi?id=318221

Repository: kdeplasma-addons

Description
-------

The current displayed value from the textfield can be copied.
Content from the clipboard can be pasted but only if the content
is a valid number

BUG: 318221

Diffs
-----

  applets/calculator/package/contents/ui/calculator.qml \
23f74bd1ac7de6b7f4519677bd96aa351a91cff1 

Diff: https://git.reviewboard.kde.org/r/123161/diff/

Testing
-------

Copying:
*) Tried copying entered numbers and results - works for me :)

Pasting:
*) Pasting "asdf" leads to nothing being pasted - correct
*) Pasting "5" appends the number to the currently entered input or replaces the \
current number in case an operator has been pressed before

Only pasting doubles is possible - no signs or full math expressions are supported. 
It looks like the plasmoid doesn't supports signed numbers in general (e.g. 5 - -5 \
doesnt result in 10)

Comments welcome :) This is my second patch so hopefully my work isn't complete \
garbage :P

Thanks,

Bernhard Friedreich

--===============6246933957315662925==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123161/">https://git.reviewboard.kde.org/r/123161/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Bernhard Friedreich.</div>

<p style="color: grey;"><i>Updated March 28, 2015, 3:18 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 16cad20c28e09109844f1e34ae87c71ae8259350 by David \
Edmundson on behalf of Bernhard Friedreich to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=318221">318221</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeplasma-addons
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The current displayed value from the textfield can be copied. Content \
from the clipboard can be pasted but only if the content is a valid number

BUG: 318221</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
                inherit;white-space: inherit;">Copying:
*) Tried copying entered numbers and results - works for me :)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
                inherit;white-space: inherit;">Pasting:
*) Pasting "asdf" leads to nothing being pasted - correct
*) Pasting "5" appends the number to the currently entered input or replaces the \
current number in case an operator has been pressed before</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Only \
pasting doubles is possible - no signs or full math expressions are supported.  It \
looks like the plasmoid doesn't supports signed numbers in general (e.g. 5 - -5 \
doesnt result in 10)</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Comments welcome :) This is my second \
patch so hopefully my work isn't complete garbage :P</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>applets/calculator/package/contents/ui/calculator.qml <span style="color: \
grey">(23f74bd1ac7de6b7f4519677bd96aa351a91cff1)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123161/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6246933957315662925==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 