From kde-panel-devel Sat Mar 28 15:18:03 2015 From: "Bernhard Friedreich" Date: Sat, 28 Mar 2015 15:18:03 +0000 To: kde-panel-devel Subject: Re: Review Request 123161: Add copy and paste support for calculator widget Message-Id: <20150328151803.17385.53831 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=142755589428860 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0381354314251361695==" --===============0381354314251361695== Content-Type: multipart/alternative; boundary="===============6246933957315662925==" --===============6246933957315662925== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123161/ ----------------------------------------------------------- (Updated March 28, 2015, 3:18 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Changes ------- Submitted with commit 16cad20c28e09109844f1e34ae87c71ae8259350 by David Edmundson on behalf of Bernhard Friedreich to branch master. Bugs: 318221 http://bugs.kde.org/show_bug.cgi?id=318221 Repository: kdeplasma-addons Description ------- The current displayed value from the textfield can be copied. Content from the clipboard can be pasted but only if the content is a valid number BUG: 318221 Diffs ----- applets/calculator/package/contents/ui/calculator.qml 23f74bd1ac7de6b7f4519677bd96aa351a91cff1 Diff: https://git.reviewboard.kde.org/r/123161/diff/ Testing ------- Copying: *) Tried copying entered numbers and results - works for me :) Pasting: *) Pasting "asdf" leads to nothing being pasted - correct *) Pasting "5" appends the number to the currently entered input or replaces the current number in case an operator has been pressed before Only pasting doubles is possible - no signs or full math expressions are supported. It looks like the plasmoid doesn't supports signed numbers in general (e.g. 5 - -5 doesnt result in 10) Comments welcome :) This is my second patch so hopefully my work isn't complete garbage :P Thanks, Bernhard Friedreich --===============6246933957315662925== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123161/

This change has been marked as submitted.

Review request for Plasma.

By Bernhard Friedreich.

Updated March 28, 2015, 3:18 p.m.

Changes

Submitted with commit 16cad20c28e09109844f1e34ae87c71ae8259350 by David Edmundson on behalf of Bernhard Friedreich to branch master.

Bugs: 318221

Repository: kdeplasma-addons

Description

The current displayed value from the textfield can be copied.
Content from the clipboard can be pasted but only if the content
is a valid number

BUG: 318221

Testing

Copying: *) Tried copying entered numbers and results - works for me :)

Pasting: *) Pasting "asdf" leads to nothing being pasted - correct *) Pasting "5" appends the number to the currently entered input or replaces the current number in case an operator has been pressed before

Only pasting doubles is possible - no signs or full math expressions are supported. It looks like the plasmoid doesn't supports signed numbers in general (e.g. 5 - -5 doesnt result in 10)

Comments welcome :) This is my second patch so hopefully my work isn't complete garbage :P

Diffs

applets/calculator/package/contents/ui/calculator.qml (23f74bd1ac7de6b7f4519677bd96aa351a91cff1)

--===============6246933957315662925==-- --===============0381354314251361695== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============0381354314251361695==--