'Re: Review Request 123142: Fixes plasma-desktop compilation with boost 1.57'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 123142: Fixes plasma-desktop compilation with boost 1.57
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2015-03-27 15:21:15
Message-ID: 20150327152115.17385.85563 () mimi ! kde ! org
[Download RAW message or body]

--===============5325214992152611381==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On March 27, 2015, 2:20 p.m., David Edmundson wrote:
> > is this redundant now?
> 
> Ivan Čukić wrote:
> Yes, Tomaz said he'll close it.

/me abuses his super admin powers.

- David

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/123142/#review78121
-----------------------------------------------------------

On March 27, 2015, 3:20 p.m., Tomaz  Canabrava wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/123142/
> -----------------------------------------------------------
> 
> (Updated March 27, 2015, 3:20 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Plasma-desktop uses Boost::optional on a few places, but it stored the value as \
> boolean ( bool thisValid  = currentValue; for instance ), the issue is that \
> boost::optional conversion to bool must be explicit, thus a static_cast is needed. 
> 
> Diffs
> -----
> 
> lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp 664b399 
> 
> Diff: https://git.reviewboard.kde.org/r/123142/diff/
> 
> 
> Testing
> -------
> 
> compiles.
> 
> 
> Thanks,
> 
> Tomaz  Canabrava
> 
> 

--===============5325214992152611381==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/123142/">https://git.reviewboard.kde.org/r/123142/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On March 27th, 2015, 2:20 p.m. UTC, <b>David \
Edmundson</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">is this redundant now?</p></pre>  </blockquote>

 <p>On March 27th, 2015, 2:49 p.m. UTC, <b>Ivan Čukić</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, \
Tomaz said he'll close it.</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">/me \
abuses his super admin powers.</p></pre> <br />

<p>- David</p>

<br />
<p>On March 27th, 2015, 3:20 p.m. UTC, Tomaz  Canabrava wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Tomaz  Canabrava.</div>

<p style="color: grey;"><i>Updated March 27, 2015, 3:20 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Plasma-desktop uses Boost::optional on a few places, \
but it stored the value as boolean ( bool thisValid  = currentValue; for instance ), \
the issue is that boost::optional conversion to bool must be explicit, thus a \
static_cast is needed.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">compiles.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp <span style="color: \
grey">(664b399)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/123142/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5325214992152611381==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 