From kde-panel-devel Fri Mar 27 15:21:15 2015 From: "David Edmundson" Date: Fri, 27 Mar 2015 15:21:15 +0000 To: kde-panel-devel Subject: Re: Review Request 123142: Fixes plasma-desktop compilation with boost 1.57 Message-Id: <20150327152115.17385.85563 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=142746969510260 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4300813449012390697==" --===============4300813449012390697== Content-Type: multipart/alternative; boundary="===============5325214992152611381==" --===============5325214992152611381== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On March 27, 2015, 2:20 p.m., David Edmundson wrote: > > is this redundant now? > > Ivan Čukić wrote: > Yes, Tomaz said he'll close it. /me abuses his super admin powers. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123142/#review78121 ----------------------------------------------------------- On March 27, 2015, 3:20 p.m., Tomaz Canabrava wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123142/ > ----------------------------------------------------------- > > (Updated March 27, 2015, 3:20 p.m.) > > > Review request for Plasma. > > > Repository: plasma-desktop > > > Description > ------- > > Plasma-desktop uses Boost::optional on a few places, but it stored the value as boolean ( bool thisValid = currentValue; for instance ), the issue is that boost::optional conversion to bool must be explicit, thus a static_cast is needed. > > > Diffs > ----- > > lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp 664b399 > > Diff: https://git.reviewboard.kde.org/r/123142/diff/ > > > Testing > ------- > > compiles. > > > Thanks, > > Tomaz Canabrava > > --===============5325214992152611381== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123142/

On March 27th, 2015, 2:20 p.m. UTC, David Edmundson wrote:
is this redundant now?
On March 27th, 2015, 2:49 p.m. UTC, Ivan Čukić wrote:
Yes, Tomaz said he'll close it.

/me abuses his super admin powers.

- David

On March 27th, 2015, 3:20 p.m. UTC, Tomaz Canabrava wrote:

Review request for Plasma.

By Tomaz Canabrava.

Updated March 27, 2015, 3:20 p.m.

Repository: plasma-desktop

Description

Plasma-desktop uses Boost::optional on a few places, but it stored the value as boolean ( bool thisValid = currentValue; for instance ), the issue is that boost::optional conversion to bool must be explicit, thus a static_cast is needed.

Testing

compiles.

Diffs

lib/kactivities-stats/src/lib/stats/resultset_iterator.cpp (664b399)

View Diff

--===============5325214992152611381==-- --===============4300813449012390697== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============4300813449012390697==--