[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 122736: [dataengines/geolocation] Use wifi data if available
From: "Jan Grulich" <jgrulich () redhat ! com>
Date: 2015-02-28 10:51:43
Message-ID: 20150228105143.12883.36536 () probe ! kde ! org
[Download RAW message or body]
--===============1466224731495615306==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
> On Úno. 27, 2015, 9:42 dop., Jan Grulich wrote:
> > dataengines/geolocation/location_ip.cpp, line 149
> > <https://git.reviewboard.kde.org/r/122736/diff/1/?file=351954#file351954line149>
> >
> > SSID is never empty (at least it shouldn't be), if it would be a hidden AP it \
> > wouldn't be listed between networks, but I think that newer NM versions make \
> > hidden APs visible anyway.
>
> Martin Gräßlin wrote:
> so how can I check for a hidden AP? They are not supposed to be sent to the \
> service.
> Jan Grulich wrote:
> I'm afraid that this is not possible.
> According to NM documentation: GetAllAccessPoints ( ) ? ao - Get the list of all \
> access points visible to this device, including hidden ones for which the SSID is \
> not yet known.
> And there is no property or flag indicating whether the AP is hidden or not.
Thinking about it and reading the docu above, maybe it will be empty. I've never used \
hidden network so I'm not sure right now.
- Jan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122736/#review76704
-----------------------------------------------------------
On Úno. 27, 2015, 9:13 dop., Martin Gräßlin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122736/
> -----------------------------------------------------------
>
> (Updated Úno. 27, 2015, 9:13 dop.)
>
>
> Review request for Plasma, Jan Grulich and Lukáš Tinkl.
>
>
> Repository: plasma-workspace
>
>
> Description
> -------
>
> Adds a dependency to NetworkManager and queries the available wifi
> access points to include in the request to the location service.
>
>
> Diffs
> -----
>
> CMakeLists.txt 8b1529e6aea7e10f89696a495c2791b6383d9489
> dataengines/geolocation/CMakeLists.txt efdcd14940b47a64b4e70dce69bdeeffdc6873f5
> dataengines/geolocation/geolocation.h fcc95086b97b6c96c0ab9bce3cac703d96d0b43e
> dataengines/geolocation/geolocation.cpp e02060e157a29902e594310102555096bd619e2e
> dataengines/geolocation/location_ip.cpp 3a13dc3018bff482c48098e1827f31c5fa3184cc
>
> Diff: https://git.reviewboard.kde.org/r/122736/diff/
>
>
> Testing
> -------
>
> Tested with my available networks and checked position on openstreetmaps. Basically \
> it even put me in the right room of the building I'm in.
>
> Thanks,
>
> Martin Gräßlin
>
>
--===============1466224731495615306==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122736/">https://git.reviewboard.kde.org/r/122736/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On únor 27th, 2015, 9:42 dop. UTC, <b>Jan \
Grulich</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/122736/diff/1/?file=351954#file351954line149" \
style="color: black; font-weight: bold; text-decoration: \
underline;">dataengines/geolocation/location_ip.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">149</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="k">if</span> <span class="p">(</span><span class="n">ssid</span><span \
class="p">.</span><span class="n">isEmpty</span><span class="p">()</span> <span \
class="o">||</span> <span class="n">ssid</span><span class="p">.</span><span \
class="n">endsWith</span><span class="p">(</span><span \
class="n">QLatin1String</span><span class="p">(</span><span \
class="s">"_nomap"</span><span class="p">)))</span> <span \
class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">SSID \
is never empty (at least it shouldn't be), if it would be a hidden AP it wouldn't be \
listed between networks, but I think that newer NM versions make hidden APs visible \
anyway.</p></pre> </blockquote>
<p>On únor 27th, 2015, 5 odp. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">so \
how can I check for a hidden AP? They are not supposed to be sent to the \
service.</p></pre> </blockquote>
<p>On únor 28th, 2015, 10:41 dop. UTC, <b>Jan Grulich</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm \
afraid that this is not possible. According to NM documentation: GetAllAccessPoints \
( ) ? ao - Get the list of all access points visible to this device, including hidden \
ones for which the SSID is not yet known.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">And there is no \
property or flag indicating whether the AP is hidden or not.</p></pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">Thinking about it and reading the docu above, maybe it will be empty. I've \
never used hidden network so I'm not sure right now.</p></pre> <br />
<p>- Jan</p>
<br />
<p>On únor 27th, 2015, 9:13 dop. UTC, Martin Gräßlin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma, Jan Grulich and Lukáš Tinkl.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated Úno. 27, 2015, 9:13 dop.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adds a dependency to NetworkManager and queries the available wifi \
access points to include in the request to the location service.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested with my available networks and checked position \
on openstreetmaps. Basically it even put me in the right room of the building I'm \
in.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: \
grey">(8b1529e6aea7e10f89696a495c2791b6383d9489)</span></li>
<li>dataengines/geolocation/CMakeLists.txt <span style="color: \
grey">(efdcd14940b47a64b4e70dce69bdeeffdc6873f5)</span></li>
<li>dataengines/geolocation/geolocation.h <span style="color: \
grey">(fcc95086b97b6c96c0ab9bce3cac703d96d0b43e)</span></li>
<li>dataengines/geolocation/geolocation.cpp <span style="color: \
grey">(e02060e157a29902e594310102555096bd619e2e)</span></li>
<li>dataengines/geolocation/location_ip.cpp <span style="color: \
grey">(3a13dc3018bff482c48098e1827f31c5fa3184cc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122736/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1466224731495615306==--
[Attachment #3 (text/plain)]
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic