--===============7291748906844717071== Content-Type: multipart/alternative; boundary="===============1466224731495615306==" --===============1466224731495615306== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On Úno. 27, 2015, 9:42 dop., Jan Grulich wrote: > > dataengines/geolocation/location_ip.cpp, line 149 > > > > > > SSID is never empty (at least it shouldn't be), if it would be a hidden AP it wouldn't be listed between networks, but I think that newer NM versions make hidden APs visible anyway. > > Martin Gräßlin wrote: > so how can I check for a hidden AP? They are not supposed to be sent to the service. > > Jan Grulich wrote: > I'm afraid that this is not possible. > According to NM documentation: GetAllAccessPoints ( ) ? ao - Get the list of all access points visible to this device, including hidden ones for which the SSID is not yet known. > > And there is no property or flag indicating whether the AP is hidden or not. Thinking about it and reading the docu above, maybe it will be empty. I've never used hidden network so I'm not sure right now. - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122736/#review76704 ----------------------------------------------------------- On Úno. 27, 2015, 9:13 dop., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122736/ > ----------------------------------------------------------- > > (Updated Úno. 27, 2015, 9:13 dop.) > > > Review request for Plasma, Jan Grulich and Lukáš Tinkl. > > > Repository: plasma-workspace > > > Description > ------- > > Adds a dependency to NetworkManager and queries the available wifi > access points to include in the request to the location service. > > > Diffs > ----- > > CMakeLists.txt 8b1529e6aea7e10f89696a495c2791b6383d9489 > dataengines/geolocation/CMakeLists.txt efdcd14940b47a64b4e70dce69bdeeffdc6873f5 > dataengines/geolocation/geolocation.h fcc95086b97b6c96c0ab9bce3cac703d96d0b43e > dataengines/geolocation/geolocation.cpp e02060e157a29902e594310102555096bd619e2e > dataengines/geolocation/location_ip.cpp 3a13dc3018bff482c48098e1827f31c5fa3184cc > > Diff: https://git.reviewboard.kde.org/r/122736/diff/ > > > Testing > ------- > > Tested with my available networks and checked position on openstreetmaps. Basically it even put me in the right room of the building I'm in. > > > Thanks, > > Martin Gräßlin > > --===============1466224731495615306== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122736/

On únor 27th, 2015, 9:42 dop. UTC, Jan Grulich wrote:

dataengines/geolocation/location_ip.cpp (Diff revision 1)
		149	if (ssid.isEmpty() \|\| ssid.endsWith(QLatin1String("_nomap"))) {

SSID is never empty (at least it shouldn't be), if it would be a hidden AP it wouldn't be listed between networks, but I think that newer NM versions make hidden APs visible anyway.

On únor 27th, 2015, 5 odp. UTC, Martin Gräßlin wrote:

so how can I check for a hidden AP? They are not supposed to be sent to the service.

On únor 28th, 2015, 10:41 dop. UTC, Jan Grulich wrote:

I'm afraid that this is not possible. According to NM documentation: GetAllAccessPoints ( ) ? ao - Get the list of all access points visible to this device, including hidden ones for which the SSID is not yet known.

And there is no property or flag indicating whether the AP is hidden or not.

Thinking about it and reading the docu above, maybe it will be empty. I've never used hidden network so I'm not sure right now.

- Jan

On únor 27th, 2015, 9:13 dop. UTC, Martin Gräßlin wrote:

Review request for Plasma, Jan Grulich and Lukáš Tinkl.

By Martin Gräßlin.

Updated Úno. 27, 2015, 9:13 dop.

Repository: plasma-workspace

Description

Adds a dependency to NetworkManager and queries the available wifi
access points to include in the request to the location service.

Testing

Tested with my available networks and checked position on openstreetmaps. Basically it even put me in the right room of the building I'm in.

Diffs

CMakeLists.txt (8b1529e6aea7e10f89696a495c2791b6383d9489)
dataengines/geolocation/CMakeLists.txt (efdcd14940b47a64b4e70dce69bdeeffdc6873f5)
dataengines/geolocation/geolocation.h (fcc95086b97b6c96c0ab9bce3cac703d96d0b43e)
dataengines/geolocation/geolocation.cpp (e02060e157a29902e594310102555096bd619e2e)
dataengines/geolocation/location_ip.cpp (3a13dc3018bff482c48098e1827f31c5fa3184cc)

--===============1466224731495615306==-- --===============7291748906844717071== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============7291748906844717071==--