'Review Request 122733: Fix path traversal checks in KPackage'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request 122733: Fix path traversal checks in KPackage
From:       "Alex Richardson" <arichardson.kde () gmail ! com>
Date:       2015-02-26 19:34:42
Message-ID: 20150226193442.12883.22786 () probe ! kde ! org
[Download RAW message or body]

--===============3052863933480036776==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122733/
-----------------------------------------------------------

Review request for KDE Frameworks, Plasma and Marco Martin.

Repository: kpackage

Description
-------

They did not canonicalize the package base directory path so it would
always fail when the package base path contained symlinks

Diffs
-----

  src/kpackage/package.cpp eb4a09b987970e89f28587426b21d63731634087 
  src/kpackage/private/package_p.h e451412fa02c88113aa4c7bbca2dcda3432b2b02 

Diff: https://git.reviewboard.kde.org/r/122733/diff/

Testing
-------

Files inside the package are now found although the install location contains a \
symlink

Thanks,

Alex Richardson

--===============3052863933480036776==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122733/">https://git.reviewboard.kde.org/r/122733/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, Plasma and Marco Martin.</div>
<div>By Alex Richardson.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kpackage
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">They did not canonicalize the package base directory \
path so it would always fail when the package base path contained symlinks</p></pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Files inside the package are now found although the \
install location contains a symlink</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kpackage/package.cpp <span style="color: \
grey">(eb4a09b987970e89f28587426b21d63731634087)</span></li>

 <li>src/kpackage/private/package_p.h <span style="color: \
grey">(e451412fa02c88113aa4c7bbca2dcda3432b2b02)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122733/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============3052863933480036776==--

[Attachment #3 (text/plain)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 