--===============4944491135975076269== Content-Type: multipart/alternative; boundary="===============3052863933480036776==" --===============3052863933480036776== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122733/ ----------------------------------------------------------- Review request for KDE Frameworks, Plasma and Marco Martin. Repository: kpackage Description ------- They did not canonicalize the package base directory path so it would always fail when the package base path contained symlinks Diffs ----- src/kpackage/package.cpp eb4a09b987970e89f28587426b21d63731634087 src/kpackage/private/package_p.h e451412fa02c88113aa4c7bbca2dcda3432b2b02 Diff: https://git.reviewboard.kde.org/r/122733/diff/ Testing ------- Files inside the package are now found although the install location contains a symlink Thanks, Alex Richardson --===============3052863933480036776== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122733/

Review request for KDE Frameworks, Plasma and Marco Martin.
By Alex Richardson.
Repository: kpackage

Description 

They did not canonicalize the package base directory path so it would
always fail when the package base path contained symlinks

Testing 

Files inside the package are now found although the install location contains a symlink

Diffs

  • src/kpackage/package.cpp (eb4a09b987970e89f28587426b21d63731634087)
  • src/kpackage/private/package_p.h (e451412fa02c88113aa4c7bbca2dcda3432b2b02)

View Diff
--===============3052863933480036776==-- --===============4944491135975076269== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KUGxhc21hLWRl dmVsIG1haWxpbmcgbGlzdApQbGFzbWEtZGV2ZWxAa2RlLm9yZwpodHRwczovL21haWwua2RlLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL3BsYXNtYS1kZXZlbAo= --===============4944491135975076269==--