[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 122171: Implement SystemTrayMenuItem::setMenu() correctly.
From: "Dmitry Shachnev" <mitya57 () gmail ! com>
Date: 2015-01-29 23:08:20
Message-ID: 20150129230820.13680.27476 () probe ! kde ! org
[Download RAW message or body]
--===============5112831371645086127==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122171/
-----------------------------------------------------------
(Updated Jan. 29, 2015, 11:08 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Repository: frameworkintegration
Description
-------
Implement SystemTrayMenuItem::setMenu() correctly.
We need to actually set the action menu, not just store it somewhere, to \
make submenus in tray icons working.
Diffs
-----
src/platformtheme/kdeplatformsystemtrayicon.h 3c1bbf7
src/platformtheme/kdeplatformsystemtrayicon.cpp d3a1d4f
Diff: https://git.reviewboard.kde.org/r/122171/diff/
Testing
-------
Tested this app: https://github.com/dglent/meteo-qt
Thanks,
Dmitry Shachnev
--===============5112831371645086127==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: \
1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122171/">https://git.reviewboard.kde.org/r/122171/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px \
gray solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" \
style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: \
6px; -webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Dmitry Shachnev.</div>
<p style="color: grey;"><i>Updated Jan. 29, 2015, 11:08 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
frameworkintegration
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Implement \
SystemTrayMenuItem::setMenu() correctly.</p> <p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">We need to actually set the action menu, not just store it \
somewhere, to make submenus in tray icons working.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">Tested this app: \
https://github.com/dglent/meteo-qt</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>src/platformtheme/kdeplatformsystemtrayicon.h <span style="color: \
grey">(3c1bbf7)</span></li>
<li>src/platformtheme/kdeplatformsystemtrayicon.cpp <span style="color: \
grey">(d3a1d4f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122171/diff/" \
style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============5112831371645086127==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic