From kde-panel-devel Thu Jan 29 23:08:20 2015 From: "Dmitry Shachnev" Date: Thu, 29 Jan 2015 23:08:20 +0000 To: kde-panel-devel Subject: Re: Review Request 122171: Implement SystemTrayMenuItem::setMenu() correctly. Message-Id: <20150129230820.13680.27476 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=142257292118236 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2535882819747228251==" --===============2535882819747228251== Content-Type: multipart/alternative; boundary="===============5112831371645086127==" --===============5112831371645086127== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122171/ ----------------------------------------------------------- (Updated Jan. 29, 2015, 11:08 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Repository: frameworkintegration Description ------- Implement SystemTrayMenuItem::setMenu() correctly. We need to actually set the action menu, not just store it somewhere, to make submenus in tray icons working. Diffs ----- src/platformtheme/kdeplatformsystemtrayicon.h 3c1bbf7 src/platformtheme/kdeplatformsystemtrayicon.cpp d3a1d4f Diff: https://git.reviewboard.kde.org/r/122171/diff/ Testing ------- Tested this app: https://github.com/dglent/meteo-qt Thanks, Dmitry Shachnev --===============5112831371645086127== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122171/

This change has been marked as submitted.

Review request for Plasma.
By Dmitry Shachnev.

Updated Jan. 29, 2015, 11:08 p.m.

Repository: frameworkintegration

Description 

Implement SystemTrayMenuItem::setMenu() correctly.


We need to actually set the action menu, not just store it somewhere, to make submenus in tray icons working.

Testing 

Tested this app: https://github.com/dglent/meteo-qt

Diffs

  • src/platformtheme/kdeplatformsystemtrayicon.h (3c1bbf7)
  • src/platformtheme/kdeplatformsystemtrayicon.cpp (d3a1d4f)

View Diff
--===============5112831371645086127==-- --===============2535882819747228251== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============2535882819747228251==--