'Re: Review Request 122167: Unlink the temporary file for ShmPool from file system'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 122167: Unlink the temporary file for ShmPool from file system
From:       Martin_Gräßlin <mgraesslin () kde ! org>
Date:       2015-01-26 10:12:18
Message-ID: 20150126101218.30682.73433 () probe ! kde ! org
[Download RAW message or body]

--===============9022814788712181544==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122167/
-----------------------------------------------------------

(Updated Jan. 26, 2015, 10:12 a.m.)

Status
------

This change has been marked as submitted.

Review request for Plasma.

Repository: kwayland

Description
-------

By using unlink() we can ensure that the file will be deleted after
the last file descriptor referring to it is closed.

QTemporaryFile didn't clean up in case of e.g. crashes.

Diffs
-----

  src/client/shm_pool.cpp c5d4a9f92ed2d4904ee999285b22b8218d8ff7f0 

Diff: https://git.reviewboard.kde.org/r/122167/diff/

Testing
-------

run kwin_wayland with KWIN_COMPOSE=Q to enforce usage of ShmPool: no file listed for \
kwin in /tmp.

Thanks,

Martin Gräßlin

--===============9022814788712181544==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122167/">https://git.reviewboard.kde.org/r/122167/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Martin Gräßlin.</div>

<p style="color: grey;"><i>Updated Jan. 26, 2015, 10:12 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwayland
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">By using unlink() we can ensure that the file will be \
deleted after the last file descriptor referring to it is closed.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">QTemporaryFile didn't clean up in case of e.g. \
crashes.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">run kwin_wayland with KWIN_COMPOSE=Q to enforce usage \
of ShmPool: no file listed for kwin in /tmp.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/client/shm_pool.cpp <span style="color: \
grey">(c5d4a9f92ed2d4904ee999285b22b8218d8ff7f0)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122167/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============9022814788712181544==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 