'Re: Review Request 122246: Add addSample(qreal value) overload'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 122246: Add addSample(qreal value) overload
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2015-01-26 9:46:40
Message-ID: 20150126094640.30683.14170 () probe ! kde ! org
[Download RAW message or body]

--===============4786424213504999711==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122246/#review74754
-----------------------------------------------------------

Ship it!

Ship It!

- Marco Martin

On Jan. 25, 2015, 3:11 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122246/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2015, 3:11 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> Add an addSample(qreal value) overload making it easier to work with just a simple \
> dataset. This way you can do plotter.addSample(50) instead of \
> plotter.addSample([50]). 
> QML seems to accept single strings for QStringList but not other list types.
> 
> 
> Diffs
> -----
> 
> src/qmlcontrols/kquickcontrolsaddons/plotter.h 3a10212 
> src/qmlcontrols/kquickcontrolsaddons/plotter.cpp 65dee7a 
> 
> Diff: https://git.reviewboard.kde.org/r/122246/diff/
> 
> 
> Testing
> -------
> 
> addSample(50) and addSample([40, 41, 42]) work
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
> 

--===============4786424213504999711==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122246/">https://git.reviewboard.kde.org/r/122246/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship \
It!</p></pre>  <br />

<p>- Marco Martin</p>

<br />
<p>On January 25th, 2015, 3:11 p.m. UTC, Kai Uwe Broulik wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma.</div>
<div>By Kai Uwe Broulik.</div>

<p style="color: grey;"><i>Updated Jan. 25, 2015, 3:11 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeclarative
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Add an addSample(qreal value) overload making it \
easier to work with just a simple dataset. This way you can do plotter.addSample(50) \
instead of plotter.addSample([50]).</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">QML seems to accept \
single strings for QStringList but not other list types.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">addSample(50) and addSample([40, 41, 42]) \
work</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/qmlcontrols/kquickcontrolsaddons/plotter.h <span style="color: \
grey">(3a10212)</span></li>

 <li>src/qmlcontrols/kquickcontrolsaddons/plotter.cpp <span style="color: \
grey">(65dee7a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122246/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============4786424213504999711==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 