'Re: Review Request 121763: Fix build on FreeBSD'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 121763: Fix build on FreeBSD
From:       "David Edmundson" <david () davidedmundson ! co ! uk>
Date:       2014-12-31 10:48:50
Message-ID: 20141231104850.18352.87016 () probe ! kde ! org
[Download RAW message or body]

--===============5793802460529865729==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121763/#review72830
-----------------------------------------------------------

Ship it!

Ship It!

- David Edmundson

On Dec. 30, 2014, 6:48 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121763/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2014, 6:48 p.m.)
> 
> 
> Review request for Plasma and Raphael Kubo da Costa.
> 
> 
> Repository: kinfocenter
> 
> 
> Description
> -------
> 
> We can't call the KCM devinfo there since we need to link against -ldevinfo
> and CMake would try to link to the KCM instead of the library in that case.
> 
> 
> Diffs
> -----
> 
> Modules/devinfo/CMakeLists.txt 2395ce3dc83080e959cbfa9f97724218cdff6bd9 
> Modules/devinfo/devinfo.desktop 1bc98a06b9a567ee45c51c7f25ee5ad6b43750d7 
> Modules/info/CMakeLists.txt 7b0e0affd13d6b556749f4a350012f27fb43ae0b 
> Modules/pci/CMakeLists.txt 5b2b30a0c3791a8add00a380e61469a96cd66ae1 
> 
> Diff: https://git.reviewboard.kde.org/r/121763/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Richardson
> 
> 

--===============5793802460529865729==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/121763/">https://git.reviewboard.kde.org/r/121763/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship \
It!</p></pre>  <br />

<p>- David Edmundson</p>

<br />
<p>On December 30th, 2014, 6:48 p.m. UTC, Alex Richardson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Plasma and Raphael Kubo da Costa.</div>
<div>By Alex Richardson.</div>

<p style="color: grey;"><i>Updated Dec. 30, 2014, 6:48 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kinfocenter
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">We can&#39;t call the KCM devinfo there since we need to link against \
-ldevinfo and CMake would try to link to the KCM instead of the library in that \
case.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>Modules/devinfo/CMakeLists.txt <span style="color: \
grey">(2395ce3dc83080e959cbfa9f97724218cdff6bd9)</span></li>

 <li>Modules/devinfo/devinfo.desktop <span style="color: \
grey">(1bc98a06b9a567ee45c51c7f25ee5ad6b43750d7)</span></li>

 <li>Modules/info/CMakeLists.txt <span style="color: \
grey">(7b0e0affd13d6b556749f4a350012f27fb43ae0b)</span></li>

 <li>Modules/pci/CMakeLists.txt <span style="color: \
grey">(5b2b30a0c3791a8add00a380e61469a96cd66ae1)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/121763/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============5793802460529865729==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 