From kde-panel-devel Wed Dec 31 10:48:50 2014 From: "David Edmundson" Date: Wed, 31 Dec 2014 10:48:50 +0000 To: kde-panel-devel Subject: Re: Review Request 121763: Fix build on FreeBSD Message-Id: <20141231104850.18352.87016 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=142002294031870 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============4276867098728718627==" --===============4276867098728718627== Content-Type: multipart/alternative; boundary="===============5793802460529865729==" --===============5793802460529865729== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121763/#review72830 ----------------------------------------------------------- Ship it! Ship It! - David Edmundson On Dec. 30, 2014, 6:48 p.m., Alex Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121763/ > ----------------------------------------------------------- > > (Updated Dec. 30, 2014, 6:48 p.m.) > > > Review request for Plasma and Raphael Kubo da Costa. > > > Repository: kinfocenter > > > Description > ------- > > We can't call the KCM devinfo there since we need to link against -ldevinfo > and CMake would try to link to the KCM instead of the library in that case. > > > Diffs > ----- > > Modules/devinfo/CMakeLists.txt 2395ce3dc83080e959cbfa9f97724218cdff6bd9 > Modules/devinfo/devinfo.desktop 1bc98a06b9a567ee45c51c7f25ee5ad6b43750d7 > Modules/info/CMakeLists.txt 7b0e0affd13d6b556749f4a350012f27fb43ae0b > Modules/pci/CMakeLists.txt 5b2b30a0c3791a8add00a380e61469a96cd66ae1 > > Diff: https://git.reviewboard.kde.org/r/121763/diff/ > > > Testing > ------- > > > Thanks, > > Alex Richardson > > --===============5793802460529865729== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121763/

Ship it!

Ship It!

- David Edmundson


On December 30th, 2014, 6:48 p.m. UTC, Alex Richardson wrote:

Review request for Plasma and Raphael Kubo da Costa.
By Alex Richardson.

Updated Dec. 30, 2014, 6:48 p.m.

Repository: kinfocenter

Description 

We can't call the KCM devinfo there since we need to link against -ldevinfo
and CMake would try to link to the KCM instead of the library in that case.

Diffs

  • Modules/devinfo/CMakeLists.txt (2395ce3dc83080e959cbfa9f97724218cdff6bd9)
  • Modules/devinfo/devinfo.desktop (1bc98a06b9a567ee45c51c7f25ee5ad6b43750d7)
  • Modules/info/CMakeLists.txt (7b0e0affd13d6b556749f4a350012f27fb43ae0b)
  • Modules/pci/CMakeLists.txt (5b2b30a0c3791a8add00a380e61469a96cd66ae1)

View Diff
--===============5793802460529865729==-- --===============4276867098728718627== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============4276867098728718627==--