'Re: Review Request 121581: Plotter in kdeclarative'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request 121581: Plotter in kdeclarative
From:       "Marco Martin" <notmart () gmail ! com>
Date:       2014-12-29 12:17:07
Message-ID: 20141229121707.18351.42462 () probe ! kde ! org
[Download RAW message or body]

--===============1241833357938854035==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121581/
-----------------------------------------------------------

(Updated Dec. 29, 2014, 12:17 p.m.)

Review request for KDE Frameworks and Plasma.

Repository: kdeclarative

Description
-------

This is an alternative, mutually exclusive to
https://gerrit.vesnicky.cesnet.cz/r/#/c/244
and dependent from
https://git.reviewboard.kde.org/r/121575/

since the plotter component doesn't depend from libplasma, it may be useful to have \
it outside of libplasma, so any applciation that wants it may use it. Any opinion \
whether this should go here or in libplasma is welcome.

Diffs (updated)
-----

  src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp 0e2eb2f 
  src/qmlcontrols/kquickcontrolsaddons/plotter.h PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/plotter.cpp PRE-CREATION 
  CMakeLists.txt 233ccce 
  cmake/Findepoxy.cmake PRE-CREATION 
  src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 786aaa5 

Diff: https://git.reviewboard.kde.org/r/121581/diff/

Testing
-------

Thanks,

Marco Martin

--===============1241833357938854035==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/121581/">https://git.reviewboard.kde.org/r/121581/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks and Plasma.</div>
<div>By Marco Martin.</div>

<p style="color: grey;"><i>Updated Dec. 29, 2014, 12:17 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kdeclarative
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is an alternative, mutually exclusive to \
https://gerrit.vesnicky.cesnet.cz/r/#/c/244 and dependent from
https://git.reviewboard.kde.org/r/121575/</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">since the plotter component doesn't depend from \
libplasma, it may be useful to have it outside of libplasma, so any applciation that \
wants it may use it. Any opinion whether this should go here or in libplasma is \
welcome.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp <span \
style="color: grey">(0e2eb2f)</span></li>

 <li>src/qmlcontrols/kquickcontrolsaddons/plotter.h <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/qmlcontrols/kquickcontrolsaddons/plotter.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>CMakeLists.txt <span style="color: grey">(233ccce)</span></li>

 <li>cmake/Findepoxy.cmake <span style="color: grey">(PRE-CREATION)</span></li>

 <li>src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt <span style="color: \
grey">(786aaa5)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/121581/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1241833357938854035==--

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel

[prev in list] [next in list] [prev in thread] [next in thread] 