From kde-panel-devel Mon Dec 29 12:17:07 2014 From: "Marco Martin" Date: Mon, 29 Dec 2014 12:17:07 +0000 To: kde-panel-devel Subject: Re: Review Request 121581: Plotter in kdeclarative Message-Id: <20141229121707.18351.42462 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=141985545630577 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2746339738318646913==" --===============2746339738318646913== Content-Type: multipart/alternative; boundary="===============1241833357938854035==" --===============1241833357938854035== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121581/ ----------------------------------------------------------- (Updated Dec. 29, 2014, 12:17 p.m.) Review request for KDE Frameworks and Plasma. Repository: kdeclarative Description ------- This is an alternative, mutually exclusive to https://gerrit.vesnicky.cesnet.cz/r/#/c/244 and dependent from https://git.reviewboard.kde.org/r/121575/ since the plotter component doesn't depend from libplasma, it may be useful to have it outside of libplasma, so any applciation that wants it may use it. Any opinion whether this should go here or in libplasma is welcome. Diffs (updated) ----- src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp 0e2eb2f src/qmlcontrols/kquickcontrolsaddons/plotter.h PRE-CREATION src/qmlcontrols/kquickcontrolsaddons/plotter.cpp PRE-CREATION CMakeLists.txt 233ccce cmake/Findepoxy.cmake PRE-CREATION src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt 786aaa5 Diff: https://git.reviewboard.kde.org/r/121581/diff/ Testing ------- Thanks, Marco Martin --===============1241833357938854035== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121581/

Review request for KDE Frameworks and Plasma.
By Marco Martin.

Updated Dec. 29, 2014, 12:17 p.m.

Repository: kdeclarative

Description 

This is an alternative, mutually exclusive to
https://gerrit.vesnicky.cesnet.cz/r/#/c/244
and dependent from
https://git.reviewboard.kde.org/r/121575/


since the plotter component doesn't depend from libplasma, it may be useful to have it outside of libplasma, so any applciation that wants it may use it.
Any opinion whether this should go here or in libplasma is welcome.

Diffs (updated)

  • src/qmlcontrols/kquickcontrolsaddons/kquickcontrolsaddonsplugin.cpp (0e2eb2f)
  • src/qmlcontrols/kquickcontrolsaddons/plotter.h (PRE-CREATION)
  • src/qmlcontrols/kquickcontrolsaddons/plotter.cpp (PRE-CREATION)
  • CMakeLists.txt (233ccce)
  • cmake/Findepoxy.cmake (PRE-CREATION)
  • src/qmlcontrols/kquickcontrolsaddons/CMakeLists.txt (786aaa5)

View Diff
--===============1241833357938854035==-- --===============2746339738318646913== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============2746339738318646913==--