[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-panel-devel
Subject: Re: Review Request 121298: Remove KGlobal check and KComponentData object that overrode applications
From: "Jeremy Whiting" <jpwhiting () kde ! org>
Date: 2014-11-30 21:58:00
Message-ID: 20141130215800.22786.39732 () probe ! kde ! org
[Download RAW message or body]
--===============7478554063306247636==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121298/
-----------------------------------------------------------
(Updated Nov. 30, 2014, 9:58 p.m.)
Status
------
This change has been marked as submitted.
Review request for Plasma.
Repository: plasma-desktop
Description
-------
Remove KGlobal check and KComponentData object that overrode applications KAboutData \
when showing dialogs.
Diffs
-----
attica-kde/kdeplugin/kdeplatformdependent.cpp \
4ade04c85db0c3efc0070bd0f288b16f3bd5882e
Diff: https://git.reviewboard.kde.org/r/121298/diff/
Testing
-------
Before this change any application that used knewstuff (and thus this plugin) showing \
a dialog would get -- attica_kde in the titlebar of the dialog. (run kanagram or \
blinken and show the about dialog to see). With this change it correctly shows the \
application name there instead.
Thanks,
Jeremy Whiting
--===============7478554063306247636==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121298/">https://git.reviewboard.kde.org/r/121298/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> <tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Plasma.</div>
<div>By Jeremy Whiting.</div>
<p style="color: grey;"><i>Updated Nov. 30, 2014, 9:58 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Remove KGlobal check and KComponentData object that \
overrode applications KAboutData when showing dialogs.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Before this change any application that used knewstuff \
(and thus this plugin) showing a dialog would get -- attica_kde in the titlebar of \
the dialog. (run kanagram or blinken and show the about dialog to see). With this \
change it correctly shows the application name there instead.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>attica-kde/kdeplugin/kdeplatformdependent.cpp <span style="color: \
grey">(4ade04c85db0c3efc0070bd0f288b16f3bd5882e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121298/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7478554063306247636==--
_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic