From kde-panel-devel Sun Nov 30 21:58:00 2014 From: "Jeremy Whiting" Date: Sun, 30 Nov 2014 21:58:00 +0000 To: kde-panel-devel Subject: Re: Review Request 121298: Remove KGlobal check and KComponentData object that overrode applications Message-Id: <20141130215800.22786.39732 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-panel-devel&m=141738470211980 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============7631834376502853546==" --===============7631834376502853546== Content-Type: multipart/alternative; boundary="===============7478554063306247636==" --===============7478554063306247636== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121298/ ----------------------------------------------------------- (Updated Nov. 30, 2014, 9:58 p.m.) Status ------ This change has been marked as submitted. Review request for Plasma. Repository: plasma-desktop Description ------- Remove KGlobal check and KComponentData object that overrode applications KAboutData when showing dialogs. Diffs ----- attica-kde/kdeplugin/kdeplatformdependent.cpp 4ade04c85db0c3efc0070bd0f288b16f3bd5882e Diff: https://git.reviewboard.kde.org/r/121298/diff/ Testing ------- Before this change any application that used knewstuff (and thus this plugin) showing a dialog would get -- attica_kde in the titlebar of the dialog. (run kanagram or blinken and show the about dialog to see). With this change it correctly shows the application name there instead. Thanks, Jeremy Whiting --===============7478554063306247636== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121298/

This change has been marked as submitted.

Review request for Plasma.

By Jeremy Whiting.

Updated Nov. 30, 2014, 9:58 p.m.

Repository: plasma-desktop

Description

Remove KGlobal check and KComponentData object that overrode applications KAboutData when showing dialogs.

Testing

Before this change any application that used knewstuff (and thus this plugin) showing a dialog would get -- attica_kde in the titlebar of the dialog. (run kanagram or blinken and show the about dialog to see). With this change it correctly shows the application name there instead.

Diffs

attica-kde/kdeplugin/kdeplatformdependent.cpp (4ade04c85db0c3efc0070bd0f288b16f3bd5882e)

View Diff

--===============7478554063306247636==-- --===============7631834376502853546== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel --===============7631834376502853546==--